linux-kernel - Re: [PATCH 2/3] bus: add Wiegand bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7WHPuhIurGHDqIE@kroah.com>
Date:   Wed, 4 Jan 2023 15:03:42 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Martin Zaťovič <m.zatovic1@...il.com>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        mani@...nel.org, hemantk@...eaurora.org, quic_jhugo@...cinc.com,
        andersson@...nel.org, Michael.Srba@...nam.cz, arnd@...db.de,
        dipenp@...dia.com, bvanassche@....org, iwona.winiarska@...el.com,
        ogabbay@...nel.org, tzimmermann@...e.de, fmdefrancesco@...il.com,
        jason.m.bills@...ux.intel.com, jae.hyun.yoo@...ux.intel.com,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org
Subject: Re: [PATCH 2/3] bus: add Wiegand bus driver

On Wed, Jan 04, 2023 at 02:34:13PM +0100, Martin Zaťovič wrote:
> Add a bus driver for Wiegand protocol. The bus driver handles
> Wiegand controller and Wiegand device managemement and driver
> matching. The bus driver defines the structures for Wiegand
> controllers and Wiegand devices. Wiegand controller structure
> contains the format and payload_len fields to add support for
> different format messages. This should be handled by the
> controller driver.
> 
> Each Wiegand controller should be associated with one Wiegand
> device, as Wiegand is typically a point-to-point bus.
> 
> Signed-off-by: Martin Zaťovič <m.zatovic1@...il.com>
> ---
>  MAINTAINERS             |   2 +
>  drivers/bus/Kconfig     |   5 +
>  drivers/bus/Makefile    |   1 +
>  drivers/bus/wiegand.c   | 768 ++++++++++++++++++++++++++++++++++++++++
>  include/linux/wiegand.h | 228 ++++++++++++
>  5 files changed, 1004 insertions(+)
>  create mode 100644 drivers/bus/wiegand.c
>  create mode 100644 include/linux/wiegand.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index db9624d93af0..b6e68e92f0e3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -22432,6 +22432,8 @@ WIEGAND BUS DRIVER
>  M:	Martin Zaťovič <m.zatovic1@...il.com>
>  S:	Maintained
>  F:	Documentation/devicetree/bindings/wiegand/wiegand-controller.yaml
> +F:	drivers/bus/wiegand.c
> +F:	include/linux/wiegand.h
>  
>  WILOCITY WIL6210 WIRELESS DRIVER
>  L:	linux-wireless@...r.kernel.org
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index 7bfe998f3514..360e55abc311 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -241,6 +241,11 @@ config VEXPRESS_CONFIG
>  	  Platform configuration infrastructure for the ARM Ltd.
>  	  Versatile Express.
>  
> +config WIEGAND
> +        tristate "Wiegand Bus driver"
> +        help
> +          Driver for low-level 2-wire serial protocol communication.

We need more information here in the help text please.

thanks,

greg k-h