linux-kernel - Re: [syzbot] [hfs?] WARNING in hfs_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 04 Jan 2023 15:43:33 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     syzbot <syzbot+7bb7cd3595533513a9e7@...kaller.appspotmail.com>,
        "Andrew Morton" <akpm@...ux-foundation.org>,
        christian.brauner@...ntu.com,
        "Damien Le Moal" <damien.lemoal@...nsource.wdc.com>,
        jlayton@...nel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com,
        "Linus Torvalds" <torvalds@...ux-foundation.org>,
        "Matthew Wilcox" <willy@...radead.org>
Subject: Re: [syzbot] [hfs?] WARNING in hfs_write_inode

On Wed, Jan 4, 2023, at 15:24, syzbot wrote:

> The issue was bisected to:
>
> commit 55d1cbbbb29e6656c662ee8f73ba1fc4777532eb
> Author: Arnd Bergmann <arnd@...db.de>
> Date:   Tue Nov 9 02:35:04 2021 +0000
>
>     hfs/hfsplus: use WARN_ON for sanity check
>

My patch was a mechanical conversion from '/* panic? */'
to 'WARN_ON()' to work around a compiler warning,
and the previous code had been in there since the
2004 HFS rewrite by Roman Zippel.

I know nothing about what this function actually does,
so my best answer is that we could revert my patch
and use pr_debug() instead of WARN_ON() for all of these.

    Arnd