linux-kernel - Re: [PATCH] mfd: pcf50633-adc: Fix potential memleak in pcf50633_adc_async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y7Wle+KbwoVTgnAr@google.com>
Date:   Wed, 4 Jan 2023 16:12:43 +0000
From:   Lee Jones <lee@...nel.org>
To:     Qiheng Lin <linqiheng@...wei.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: pcf50633-adc: Fix potential memleak in
 pcf50633_adc_async_read()

On Thu, 08 Dec 2022, Qiheng Lin wrote:

> `req` is allocated in pcf50633_adc_async_read(), but
> adc_enqueue_request() could fail to insert the `req` into queue.
> We need to check the return value and free it in the case of failure.
> 
> Fixes: 08c3e06a5eb2 ("mfd: PCF50633 adc driver")
> Signed-off-by: Qiheng Lin <linqiheng@...wei.com>
> ---
>  drivers/mfd/pcf50633-adc.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Applied, thanks

-- 
Lee Jones [李琼斯]