[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7dac372b-167c-2dff-b207-6e32fd40c7bb@quicinc.com>
Date: Wed, 4 Jan 2023 10:57:20 +0800
From: Baochen Qiang <quic_bqiang@...cinc.com>
To: Jeffrey Hugo <jeffrey.l.hugo@...il.com>
CC: <manivannan.sadhasivam@...aro.org>,
<linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<ath11k@...ts.infradead.org>
Subject: Re: [PATCH] bus: mhi: host: Change the log levels for SYS_ERR event
On 1/4/2023 10:41 AM, Jeffrey Hugo wrote:
> Why was this not sent to the MHI mailing list?
I don't know the MHI mailing list address, could tell me that?
>
> On Tue, Jan 3, 2023 at 7:19 PM Baochen Qiang <quic_bqiang@...cinc.com> wrote:
>> Currently no log printed when SYS_ERR happens, this makes
>> debug quite hard, so change log level to make it noisy.
> You are going to need to explain this more.
> There are two drivers in the upstream kernel that are MHI clients -
> pci_generic and ath11k.
> I'm assuming that you care about ath11k because you included that mail list.
Yes, I am talking about ath11k.
> In ath11k_mhi_op_status_cb() I see a warning message printed when the
> syserr callback is triggered.
> I see something similar in pci_generic.
>
> Looks like a log is printed when SYS_ERR happens in all possible
> scenarios, so I don't understand the point of this change.
> Particularly given that dev_dbg messages can be trivially enabled.
>
> -Jeff
Well, this is not true in some cases. For example, we have met cases where
WLAN HW/firmware is not working well, and only send a SYS_ERR event to MHI
driver, however this event is not sent to ath11k host becuase of
mhi_pm_sys_err_handler(),
so we got no log at all.
Powered by blists - more mailing lists