linux-kernel - Re: [PATCH rcu 27/27] rcu: Remove CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230105152351.GP4028633@paulmck-ThinkPad-P17-Gen-1>
Date:   Thu, 5 Jan 2023 07:23:51 -0800
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     John Ogness <john.ogness@...utronix.de>
Cc:     rcu@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...a.com, rostedt@...dmis.org,
        Petr Mladek <pmladek@...e.com>
Subject: Re: [PATCH rcu 27/27] rcu: Remove CONFIG_SRCU

On Thu, Jan 05, 2023 at 09:10:16AM +0106, John Ogness wrote:
> On 2023-01-04, "Paul E. McKenney" <paulmck@...nel.org> wrote:
> > Now that all references to CONFIG_SRCU have been removed, it is time to
> > remove CONFIG_SRCU itself.
> 
> I think "all references" is a bit misleading since there still are
> several places in the kernel code that use it:
> 
> $ git grep CONFIG_SRCU
> drivers/base/core.c:#ifdef CONFIG_SRCU
> drivers/base/core.c:#else /* !CONFIG_SRCU */
> drivers/base/core.c:#endif /* !CONFIG_SRCU */
> fs/locks.c:#if IS_ENABLED(CONFIG_SRCU)
> fs/locks.c:#else /* !IS_ENABLED(CONFIG_SRCU) */
> fs/locks.c:#endif /* IS_ENABLED(CONFIG_SRCU) */
> kernel/notifier.c:#ifdef CONFIG_SRCU
> kernel/notifier.c:#endif /* CONFIG_SRCU */

In the -rcu tree, these are removed by these commits:

1798c5b6b0ea ("drivers/base: Remove CONFIG_SRCU")
19aa50512372 ("fs: Remove CONFIG_SRCU")
fe0c9bd625ad ("kernel/notifier: Remove CONFIG_SRCU")

> Should those be removed before this patch?

When I merge the -rcu tree's "dev" branch with current mainline, "git
grep CONFIG_SRCU" gives me no output.  Am I fat-fingering something here?

							Thanx, Paul