linux-kernel - Re: [PATCH rcu 18/27] fs/btrfs: Remove "select SRCU"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230105154119.GT4028633@paulmck-ThinkPad-P17-Gen-1>
Date:   Thu, 5 Jan 2023 07:41:19 -0800
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Qu Wenruo <wqu@...e.com>
Cc:     rcu@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...a.com, rostedt@...dmis.org,
        Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org
Subject: Re: [PATCH rcu 18/27] fs/btrfs: Remove "select SRCU"

On Thu, Jan 05, 2023 at 05:06:09PM +0800, Qu Wenruo wrote:
> 
> 
> On 2023/1/5 08:38, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it.  Therefore, remove the "select SRCU"
> > Kconfig statements.
> > 
> > Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> > Cc: Chris Mason <clm@...com>
> > Cc: Josef Bacik <josef@...icpanda.com>
> > Cc: David Sterba <dsterba@...e.com>
> > Cc: <linux-btrfs@...r.kernel.org>
> 
> In fact, since commit c75e839414d3 ("btrfs: kill the subvol_srcu"), we can
> completely remove any SRCU related configs and even includes.

$ git grep srcu fs/btrfs/
fs/btrfs/disk-io.h: *   fs_info->subvol_srcu

I know that situation.  ;-)

> Reviewed-by: Qu Wenruo <wqu@...e.com>

Thank you!  I will update on my next rebase.

							Thanx, Paul

> Thanks,
> Qu
> 
> > ---
> >   fs/btrfs/Kconfig | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
> > index 183e5c4aed348..37b6bab90c835 100644
> > --- a/fs/btrfs/Kconfig
> > +++ b/fs/btrfs/Kconfig
> > @@ -17,7 +17,6 @@ config BTRFS_FS
> >   	select FS_IOMAP
> >   	select RAID6_PQ
> >   	select XOR_BLOCKS
> > -	select SRCU
> >   	depends on PAGE_SIZE_LESS_THAN_256KB
> >   	help