| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202301052334.Q6GJFByn-lkp@intel.com>
Date: Fri, 6 Jan 2023 00:06:27 +0800
From: kernel test robot <lkp@...el.com>
To: James Houghton <jthoughton@...gle.com>,
Mike Kravetz <mike.kravetz@...cle.com>,
Muchun Song <songmuchun@...edance.com>,
Peter Xu <peterx@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev,
David Hildenbrand <david@...hat.com>,
David Rientjes <rientjes@...gle.com>,
Axel Rasmussen <axelrasmussen@...gle.com>,
Mina Almasry <almasrymina@...gle.com>,
Zach O'Keefe <zokeefe@...gle.com>,
Manish Mishra <manish.mishra@...anix.com>,
Naoya Horiguchi <naoya.horiguchi@....com>,
"Dr . David Alan Gilbert" <dgilbert@...hat.com>,
"Matthew Wilcox (Oracle)" <willy@...radead.org>,
Vlastimil Babka <vbabka@...e.cz>,
Baolin Wang <baolin.wang@...ux.alibaba.com>,
Miaohe Lin <linmiaohe@...wei.com>,
Yang Shi <shy828301@...il.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Linux Memory Management List <linux-mm@...ck.org>,
linux-kernel@...r.kernel.org,
James Houghton <jthoughton@...gle.com>
Subject: Re: [PATCH 11/46] hugetlb: add hugetlb_pte to track HugeTLB page
table entries
Hi James,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20230105]
[cannot apply to kvm/queue shuah-kselftest/next shuah-kselftest/fixes arnd-asm-generic/master linus/master kvm/linux-next v6.2-rc2 v6.2-rc1 v6.1 v6.2-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/James-Houghton/hugetlb-don-t-set-PageUptodate-for-UFFDIO_CONTINUE/20230105-182428
patch link: https://lore.kernel.org/r/20230105101844.1893104-12-jthoughton%40google.com
patch subject: [PATCH 11/46] hugetlb: add hugetlb_pte to track HugeTLB page table entries
config: m68k-allmodconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/2f657c22d05e0d32f2dfb41cb3a79a705bd9e37c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review James-Houghton/hugetlb-don-t-set-PageUptodate-for-UFFDIO_CONTINUE/20230105-182428
git checkout 2f657c22d05e0d32f2dfb41cb3a79a705bd9e37c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash kernel/ mm/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All error/warnings (new ones prefixed by >>):
In file included from include/linux/migrate.h:8,
from mm/zsmalloc.c:60:
>> include/linux/hugetlb.h:1284:40: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration
1284 | spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte)
| ^~~~~~~~~~~
include/linux/hugetlb.h: In function 'hugetlb_pte_lockptr':
>> include/linux/hugetlb.h:1286:20: error: invalid use of undefined type 'struct hugetlb_pte'
1286 | return hpte->ptl;
| ^~
include/linux/hugetlb.h: At top level:
include/linux/hugetlb.h:1290:37: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration
1290 | spinlock_t *hugetlb_pte_lock(struct hugetlb_pte *hpte)
| ^~~~~~~~~~~
include/linux/hugetlb.h: In function 'hugetlb_pte_lock':
>> include/linux/hugetlb.h:1292:47: error: passing argument 1 of 'hugetlb_pte_lockptr' from incompatible pointer type [-Werror=incompatible-pointer-types]
1292 | spinlock_t *ptl = hugetlb_pte_lockptr(hpte);
| ^~~~
| |
| struct hugetlb_pte *
include/linux/hugetlb.h:1284:53: note: expected 'struct hugetlb_pte *' but argument is of type 'struct hugetlb_pte *'
1284 | spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte)
| ~~~~~~~~~~~~~~~~~~~~^~~~
include/linux/hugetlb.h: At top level:
include/linux/hugetlb.h:1301:32: warning: 'enum hugetlb_level' declared inside parameter list will not be visible outside of this definition or declaration
1301 | enum hugetlb_level level)
| ^~~~~~~~~~~~~
include/linux/hugetlb.h:1299:56: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration
1299 | void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte,
| ^~~~~~~~~~~
>> include/linux/hugetlb.h:1301:46: error: parameter 5 ('level') has incomplete type
1301 | enum hugetlb_level level)
| ~~~~~~~~~~~~~~~~~~~^~~~~
>> include/linux/hugetlb.h:1299:6: error: function declaration isn't a prototype [-Werror=strict-prototypes]
1299 | void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte,
| ^~~~~~~~~~~~~~~~~~~~
include/linux/hugetlb.h: In function 'hugetlb_pte_populate':
>> include/linux/hugetlb.h:1303:9: error: implicit declaration of function '__hugetlb_pte_populate'; did you mean 'hugetlb_pte_populate'? [-Werror=implicit-function-declaration]
1303 | __hugetlb_pte_populate(hpte, ptep, shift, level,
| ^~~~~~~~~~~~~~~~~~~~~~
| hugetlb_pte_populate
cc1: some warnings being treated as errors
--
In file included from kernel/fork.c:52:
>> include/linux/hugetlb.h:1284:40: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration
1284 | spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte)
| ^~~~~~~~~~~
include/linux/hugetlb.h: In function 'hugetlb_pte_lockptr':
>> include/linux/hugetlb.h:1286:20: error: invalid use of undefined type 'struct hugetlb_pte'
1286 | return hpte->ptl;
| ^~
include/linux/hugetlb.h: At top level:
include/linux/hugetlb.h:1290:37: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration
1290 | spinlock_t *hugetlb_pte_lock(struct hugetlb_pte *hpte)
| ^~~~~~~~~~~
include/linux/hugetlb.h: In function 'hugetlb_pte_lock':
>> include/linux/hugetlb.h:1292:47: error: passing argument 1 of 'hugetlb_pte_lockptr' from incompatible pointer type [-Werror=incompatible-pointer-types]
1292 | spinlock_t *ptl = hugetlb_pte_lockptr(hpte);
| ^~~~
| |
| struct hugetlb_pte *
include/linux/hugetlb.h:1284:53: note: expected 'struct hugetlb_pte *' but argument is of type 'struct hugetlb_pte *'
1284 | spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte)
| ~~~~~~~~~~~~~~~~~~~~^~~~
include/linux/hugetlb.h: At top level:
include/linux/hugetlb.h:1301:32: warning: 'enum hugetlb_level' declared inside parameter list will not be visible outside of this definition or declaration
1301 | enum hugetlb_level level)
| ^~~~~~~~~~~~~
include/linux/hugetlb.h:1299:56: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration
1299 | void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte,
| ^~~~~~~~~~~
>> include/linux/hugetlb.h:1301:46: error: parameter 5 ('level') has incomplete type
1301 | enum hugetlb_level level)
| ~~~~~~~~~~~~~~~~~~~^~~~~
>> include/linux/hugetlb.h:1299:6: error: function declaration isn't a prototype [-Werror=strict-prototypes]
1299 | void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte,
| ^~~~~~~~~~~~~~~~~~~~
include/linux/hugetlb.h: In function 'hugetlb_pte_populate':
>> include/linux/hugetlb.h:1303:9: error: implicit declaration of function '__hugetlb_pte_populate'; did you mean 'hugetlb_pte_populate'? [-Werror=implicit-function-declaration]
1303 | __hugetlb_pte_populate(hpte, ptep, shift, level,
| ^~~~~~~~~~~~~~~~~~~~~~
| hugetlb_pte_populate
kernel/fork.c: At top level:
kernel/fork.c:162:13: warning: no previous prototype for 'arch_release_task_struct' [-Wmissing-prototypes]
162 | void __weak arch_release_task_struct(struct task_struct *tsk)
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/fork.c:862:20: warning: no previous prototype for 'arch_task_cache_init' [-Wmissing-prototypes]
862 | void __init __weak arch_task_cache_init(void) { }
| ^~~~~~~~~~~~~~~~~~~~
kernel/fork.c:957:12: warning: no previous prototype for 'arch_dup_task_struct' [-Wmissing-prototypes]
957 | int __weak arch_dup_task_struct(struct task_struct *dst,
| ^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from mm/madvise.c:16:
>> include/linux/hugetlb.h:1284:40: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration
1284 | spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte)
| ^~~~~~~~~~~
include/linux/hugetlb.h: In function 'hugetlb_pte_lockptr':
>> include/linux/hugetlb.h:1286:20: error: invalid use of undefined type 'struct hugetlb_pte'
1286 | return hpte->ptl;
| ^~
include/linux/hugetlb.h: At top level:
include/linux/hugetlb.h:1290:37: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration
1290 | spinlock_t *hugetlb_pte_lock(struct hugetlb_pte *hpte)
| ^~~~~~~~~~~
include/linux/hugetlb.h: In function 'hugetlb_pte_lock':
>> include/linux/hugetlb.h:1292:47: error: passing argument 1 of 'hugetlb_pte_lockptr' from incompatible pointer type [-Werror=incompatible-pointer-types]
1292 | spinlock_t *ptl = hugetlb_pte_lockptr(hpte);
| ^~~~
| |
| struct hugetlb_pte *
include/linux/hugetlb.h:1284:53: note: expected 'struct hugetlb_pte *' but argument is of type 'struct hugetlb_pte *'
1284 | spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte)
| ~~~~~~~~~~~~~~~~~~~~^~~~
include/linux/hugetlb.h: At top level:
include/linux/hugetlb.h:1301:32: warning: 'enum hugetlb_level' declared inside parameter list will not be visible outside of this definition or declaration
1301 | enum hugetlb_level level)
| ^~~~~~~~~~~~~
include/linux/hugetlb.h:1299:56: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration
1299 | void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte,
| ^~~~~~~~~~~
>> include/linux/hugetlb.h:1301:46: error: parameter 5 ('level') has incomplete type
1301 | enum hugetlb_level level)
| ~~~~~~~~~~~~~~~~~~~^~~~~
>> include/linux/hugetlb.h:1299:6: error: function declaration isn't a prototype [-Werror=strict-prototypes]
1299 | void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte,
| ^~~~~~~~~~~~~~~~~~~~
include/linux/hugetlb.h: In function 'hugetlb_pte_populate':
>> include/linux/hugetlb.h:1303:9: error: implicit declaration of function '__hugetlb_pte_populate'; did you mean 'hugetlb_pte_populate'? [-Werror=implicit-function-declaration]
1303 | __hugetlb_pte_populate(hpte, ptep, shift, level,
| ^~~~~~~~~~~~~~~~~~~~~~
| hugetlb_pte_populate
mm/madvise.c: In function 'madvise_split':
mm/madvise.c:1023:9: error: implicit declaration of function 'hugetlb_vma_lock_alloc'; did you mean 'hugetlb_vma_lock_write'? [-Werror=implicit-function-declaration]
1023 | hugetlb_vma_lock_alloc(vma);
| ^~~~~~~~~~~~~~~~~~~~~~
| hugetlb_vma_lock_write
cc1: some warnings being treated as errors
vim +1286 include/linux/hugetlb.h
1282
1283 static inline
> 1284 spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte)
1285 {
> 1286 return hpte->ptl;
1287 }
1288
1289 static inline
1290 spinlock_t *hugetlb_pte_lock(struct hugetlb_pte *hpte)
1291 {
> 1292 spinlock_t *ptl = hugetlb_pte_lockptr(hpte);
1293
1294 spin_lock(ptl);
1295 return ptl;
1296 }
1297
1298 static inline
> 1299 void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte,
1300 pte_t *ptep, unsigned int shift,
> 1301 enum hugetlb_level level)
1302 {
> 1303 __hugetlb_pte_populate(hpte, ptep, shift, level,
1304 huge_pte_lockptr(shift, mm, ptep));
1305 }
1306
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
View attachment "config" of type "text/plain" (279235 bytes)
Powered by blists - more mailing lists