linux-kernel - Re: [PATCH v2] mm: Remove an ambiguous sentence from kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y7cB069naGgBCTIA@iweiny-desk3>
Date:   Thu, 5 Jan 2023 08:58:59 -0800
From:   Ira Weiny <ira.weiny@...el.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Alexander Potapenko <glider@...gle.com>,
        "Bagas Sanjaya" <bagasdotme@...il.com>,
        Andrey Konovalov <andreyknvl@...il.com>,
        Tony Luck <tony.luck@...el.com>,
        <linux-kernel@...r.kernel.org>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        <linux-mm@...ck.org>
Subject: Re: [PATCH v2] mm: Remove an ambiguous sentence from
 kmap_local_folio() kdocs

On Thu, Jan 05, 2023 at 01:04:24PM +0100, Fabio M. De Francesco wrote:
> In the kdocs of kmap_local_folio() there is a an ambiguous sentence
> which suggests to use this API "only when really necessary".
> 
> On the contrary, since kmap() and kmap_atomic() are deprecated, both
> kmap_local_folio(), as well as kmap_local_page(), must be preferred
> to the previous ones.
> 
> Therefore, remove the above-mentioned sentence exactly how it has
> previously been done for the kmap_local_page() kdocs in
> commit 72f1c55adf70 ("highmem: delete a sentence from kmap_local_page() kdocs").
> 
> Cc: Ira Weiny <ira.weiny@...el.com>

Reviewed-by: Ira Weiny <ira.weiny@...el.com>

> Cc: Matthew Wilcox (Oracle) <willy@...radead.org>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>
> ---
>  include/linux/highmem.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/highmem.h b/include/linux/highmem.h
> index 44242268f53b..7b0085a61e67 100644
> --- a/include/linux/highmem.h
> +++ b/include/linux/highmem.h
> @@ -120,8 +120,7 @@ static inline void *kmap_local_page(struct page *page);
>   * temporarily mapped.
>   *
>   * While it is significantly faster than kmap() for the higmem case it
> - * comes with restrictions about the pointer validity. Only use when really
> - * necessary.
> + * comes with restrictions about the pointer validity.
>   *
>   * On HIGHMEM enabled systems mapping a highmem page has the side effect of
>   * disabling migration in order to keep the virtual address stable across
> -- 
> 2.39.0
>