linux-kernel - Re: [PATCH 4.9 000/251] 4.9.337-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7cpWKbQlNW5qEeO@duo.ucw.cz>
Date:   Thu, 5 Jan 2023 20:47:36 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>, nathan@...nel.org,
        marcus.folkesson@...il.com, cuigaosheng1@...wei.com,
        andriy.shevchenko@...ux.intel.com, m.szyprowski@...sung.com,
        jack@...e.cz
Cc:     stable@...r.kernel.org, patches@...ts.linux.dev,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
        patches@...nelci.org, lkft-triage@...ts.linaro.org, pavel@...x.de,
        jonathanh@...dia.com, f.fainelli@...il.com,
        sudipm.mukherjee@...il.com, srw@...dewatkins.net, rwarsow@....de
Subject: Re: [PATCH 4.9 000/251] 4.9.337-rc1 review

Hi!

> This is the start of the stable review cycle for the 4.9.337 release.
> There are 251 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.

These are kCFI fixes, we don't really need them in 4.9:

> Nathan Chancellor <nathan@...nel.org>
>     net: ethernet: ti: Fix return type of netcp_ndo_start_xmit()
> Nathan Chancellor <nathan@...nel.org>
>     hamradio: baycom_epp: Fix return type of baycom_send_packet()
> Nathan Chancellor <nathan@...nel.org>
>     drm/fsl-dcu: Fix return type of fsl_dcu_drm_connector_mode_valid()
> Nathan Chancellor <nathan@...nel.org>
>     drm/sti: Fix return type of sti_{dvo,hda,hdmi}_connector_mode_valid()

This is marked as not-for-stable, and does not fix anything really
bad, just smatch warning:

> Marcus Folkesson <marcus.folkesson@...il.com>
>     HID: hid-sensor-custom: set fixed size for custom attributes

This is quite wrong. Real bug is registering the interrupt before the
device is set up -- it should be fixed by reordering the init code,
not by checking for NULL.

> Gaosheng Cui <cuigaosheng1@...wei.com>
>     ALSA: mts64: fix possible null-ptr-defer in snd_mts64_interrupt

This may turn working config into non-working for someone, as people
now need to enable PWM manually to get fully working driver. I don't
think we want it in stable.

> Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>     fbdev: ssd1307fb: Drop optional dependency

This claims to fix a deadlock, but in turn it calls
cancel_delayed_work_sync from interrupt handler. I don't think that is
good idea.

> Marek Szyprowski <m.szyprowski@...sung.com>
>     ASoC: wm8994: Fix potential deadlock

This one is okay in mainline, but contains wrong error handling in the
4.9 backport. 4.19 seems okay. It needs to "goto out_unlock", not
return directly.

> Jan Kara <jack@...e.cz>
>     ext4: initialize quota before expanding inode in setproject ioctl

Best regards,
								Pavel

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)