linux-kernel - Re: [PATCH] x86/lib: Do not use local symbols with SYM_CODE_START

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <48498199-175D-467B-942B-9F8A923B8930@gmail.com>
Date:   Thu, 5 Jan 2023 12:33:54 -0800
From:   Nadav Amit <nadav.amit@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/lib: Do not use local symbols with
 SYM_CODE_START_LOCAL()



> On Nov 21, 2022, at 11:15 PM, Nadav Amit <nadav.amit@...il.com> wrote:
> 
> From: Nadav Amit <namit@...are.com>
> 
> When SYM_CODE_START_LOCAL() is used, the symbols are local but should be
> saved to the object. In contrast, using ".L" label prefix causes the
> symbols not to be saved in the object.
> 
> Since it is preferable to be able to map instruction pointers back to
> symbols, the local symbol should be saved in the object. Therefore, when
> SYM_CODE_START_LOCAL() is used, the ".L" label prefix should not be
> used.
> 
> Two symbols, however, have both SYM_CODE_START_LOCAL() and ".L" prefix:
> .Lbad_put_user_clac and .Lcopy_user_handle_tail. Remove the ".L" prefix
> from them.
> 
> No functional change, other then emitting these symbols into the object,
> is intended.
> 
> Signed-off-by: Nadav Amit <namit@...are.com>

Ping.