[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9841589c-757e-ea01-0c55-abe4a38fae03@intel.com>
Date: Thu, 5 Jan 2023 23:31:09 +0200
From: Adrian Hunter <adrian.hunter@...el.com>
To: Victor Shih <victorshihgli@...il.com>, ulf.hansson@...aro.org
Cc: linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
benchuanggli@...il.com, HL.Liu@...esyslogic.com.tw,
Greg.tu@...esyslogic.com.tw, takahiro.akashi@...aro.org,
dlunev@...omium.org, Victor Shih <victor.shih@...esyslogic.com.tw>,
Ben Chuang <ben.chuang@...esyslogic.com.tw>
Subject: Re: [PATCH V6 22/24] mmc: sdhci-uhs2: add post-mmc_attach_sd hook
On 13/12/22 11:00, Victor Shih wrote:
> From: Ben Chuang <ben.chuang@...esyslogic.com.tw>
>
> This "post" hook for mmc_attach_sd(), uhs2_post_attach_sd, will be required
> to enable UHS-II support, at least, on GL9755.
>
> Signed-off-by: Ben Chuang <ben.chuang@...esyslogic.com.tw>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@...aro.org>
> ---
> drivers/mmc/host/sdhci.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index e5f64b38e339..4aac22b58d79 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -728,6 +728,7 @@ struct sdhci_ops {
> void (*dump_vendor_regs)(struct sdhci_host *host);
> void (*dump_uhs2_regs)(struct sdhci_host *host);
> void (*uhs2_pre_detect_init)(struct sdhci_host *host);
> + void (*uhs2_post_attach_sd)(struct sdhci_host *host);
This gets called already in "mmc: sdhci-uhs2: add uhs2_control()
to initialise the interface"
Either move that line to this patch or vice versa.
Please check compiling after each patch is applied.
> };
>
> #ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS
Powered by blists - more mailing lists