linux-kernel - Re: [PATCH v3 7/7] ufs: core: Add advanced RPMB support in ufs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81a10cd9-7b0b-e982-5d24-5f0438e37b63@acm.org>
Date:   Thu, 5 Jan 2023 14:37:17 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Bean Huo <beanhuo@...pp.de>, alim.akhtar@...sung.com,
        avri.altman@....com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, stanley.chu@...iatek.com,
        beanhuo@...ron.com, tomas.winkler@...el.com,
        daejun7.park@...sung.com, quic_cang@...cinc.com,
        quic_nguyenb@...cinc.com, quic_xiaosenh@...cinc.com,
        quic_richardp@...cinc.com, quic_asutoshd@...cinc.com, hare@...e.de
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 7/7] ufs: core: Add advanced RPMB support in ufs_bsg

On 12/1/22 06:04, Bean Huo wrote:
> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
> index 5cf81dff60aa..c3dfa8084b5c 100644
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> +int ufshcd_advanced_rpmb_req_handler(struct ufs_hba *hba, struct utp_upiu_req *req_upiu,
> +				     struct utp_upiu_req *rsp_upiu, struct ufs_ehs *ehs_req,
> +				     struct ufs_ehs *ehs_rsp, int sg_cnt,
> +				     struct scatterlist *sg_list, enum dma_data_direction dir);

Hi Bean,

I think this patch is the first patch that adds a declaration in 
ufshcd.h that uses the enum dma_data_direction data type. That leads to 
the following compiler warning:

In file included from drivers/ufs/host/tc-dwc-g210-pci.c:10:
./include/ufs/ufshcd.h:1282:72: warning: ‘enum dma_data_direction’ 
declared inside parameter list will not be visible outside of this 
definition or declaration
  1282 |                                      struct scatterlist 
*sg_list, enum dma_data_direction dir);
       | 
        ^~~~~~~~~~~~~~~~~~

Can you please post a patch to fix this? Adding the following line is 
probably sufficient:

#include <linux/dma-direction.h>

This has been detected with the following script:
https://github.com/bvanassche/build-scsi-drivers/blob/main/build-scsi-drivers

Thanks,

Bart.