linux-kernel - Re: [PATCH v2 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuCfpGHMeWSSp+ge3pPppLrQ5BpGiga=fjKmDk65GTjFDV=3w@mail.gmail.com>
Date:   Wed, 4 Jan 2023 18:39:52 -0800
From:   Suren Baghdasaryan <surenb@...gle.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     hughd@...gle.com, hannes@...xchg.org, david@...hat.com,
        vincent.whitchurch@...s.com, seanjc@...gle.com, rppt@...nel.org,
        shy828301@...il.com, pasha.tatashin@...een.com,
        paul.gortmaker@...driver.com, peterx@...hat.com, vbabka@...e.cz,
        Liam.Howlett@...cle.com, ccross@...gle.com, willy@...radead.org,
        arnd@...db.de, cgel.zte@...il.com, yuzhao@...gle.com,
        bagasdotme@...il.com, suleiman@...gle.com, steven@...uorix.net,
        heftig@...hlinux.org, cuigaosheng1@...wei.com,
        kirill@...temov.name, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        syzbot+91edf9178386a07d06a7@...kaller.appspotmail.com
Subject: Re: [PATCH v2 1/1] mm: fix vma->anon_name memory leak for anonymous
 shmem VMAs

On Wed, Jan 4, 2023 at 5:38 PM Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> On Wed,  4 Jan 2023 16:02:40 -0800 Suren Baghdasaryan <surenb@...gle.com> wrote:
>
> > free_anon_vma_name() is missing a check for anonymous shmem VMA which
> > leads to a memory leak due to refcount not being dropped.  Fix this by
> > calling anon_vma_name_put() unconditionally. It will free vma->anon_name
> > whenever it's non-NULL.
> >
> > Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming")
>
> A cc:stable is appropriate here, yes?

Hmm. The patch we are fixing here was merged in 6.2-rc1. Should I CC
stable to fix the previous -rc branch?