linux-kernel - Re: [PATCH 1/3] dt-bindings: add Wiegand controller dt-binding documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <167288699743.3289802.11416300260059460595.robh@kernel.org>
Date:   Wed, 04 Jan 2023 20:53:58 -0600
From:   Rob Herring <robh@...nel.org>
To:     Martin Zaťovič <m.zatovic1@...il.com>
Cc:     bvanassche@....org, mani@...nel.org, linux-kernel@...r.kernel.org,
        andersson@...nel.org, iwona.winiarska@...el.com,
        tzimmermann@...e.de, robh+dt@...nel.org, Michael.Srba@...nam.cz,
        krzysztof.kozlowski+dt@...aro.org, devicetree@...r.kernel.org,
        hemantk@...eaurora.org, quic_jhugo@...cinc.com, dipenp@...dia.com,
        fmdefrancesco@...il.com, jason.m.bills@...ux.intel.com,
        jae.hyun.yoo@...ux.intel.com, ogabbay@...nel.org, arnd@...db.de,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH 1/3] dt-bindings: add Wiegand controller dt-binding documentation

On Wed, 04 Jan 2023 14:34:12 +0100, Martin Zaťovič wrote:
> A Weigand bus is defined by a Wiegand controller node. This node
> can contain one or more device nodes for devices attached to
> the controller(it is advised to only connect one device as Wiegand
> is a point-to-point bus).
> 
> Wiegand controller needs to specify several attributes such as
> the pulse length in order to function properly. These attributes
> are documented here.
> 
> Signed-off-by: Martin Zaťovič <m.zatovic1@...il.com>
> ---
>  .../bindings/wiegand/wiegand-controller.yaml  | 83 +++++++++++++++++++
>  MAINTAINERS                                   |  5 ++
>  2 files changed, 88 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/wiegand/wiegand-controller.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/wiegand/wiegand-controller.example.dts:20.40-41 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/wiegand/wiegand-controller.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1508: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230104133414.39305-2-m.zatovic1@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.