[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202301042032.C293ACB95@keescook>
Date: Wed, 4 Jan 2023 20:33:16 -0800
From: Kees Cook <keescook@...omium.org>
To: Jens Axboe <axboe@...nel.dk>
Cc: Pavel Begunkov <asml.silence@...il.com>,
"Gustavo A. R. Silva" <gustavoars@...nel.org>,
stable@...r.kernel.org, io-uring@...r.kernel.org,
Dylan Yudaken <dylany@...com>, linux-kernel@...r.kernel.org,
linux-hardening@...r.kernel.org
Subject: Re: [PATCH] io_uring: Replace 0-length array with flexible array
On Wed, Jan 04, 2023 at 07:37:48PM -0800, Kees Cook wrote:
> Zero-length arrays are deprecated[1]. Replace struct io_uring_buf_ring's
> "bufs" with a flexible array member. (How is the size of this array
> verified?) Detected with GCC 13, using -fstrict-flex-arrays=3:
>
> In function 'io_ring_buffer_select',
> inlined from 'io_buffer_select' at io_uring/kbuf.c:183:10:
> io_uring/kbuf.c:141:23: warning: array subscript 255 is outside the bounds of an interior zero-length array 'struct io_uring_buf[0]' [-Wzero-length-bounds]
> 141 | buf = &br->bufs[head];
> | ^~~~~~~~~~~~~~~
> In file included from include/linux/io_uring.h:7,
> from io_uring/kbuf.c:10:
> include/uapi/linux/io_uring.h: In function 'io_buffer_select':
> include/uapi/linux/io_uring.h:628:41: note: while referencing 'bufs'
> 628 | struct io_uring_buf bufs[0];
> | ^~~~
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
>
> Fixes: c7fb19428d67 ("io_uring: add support for ring mapped supplied buffers")
> Cc: Jens Axboe <axboe@...nel.dk>
> Cc: Pavel Begunkov <asml.silence@...il.com>
> Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>
> Cc: stable@...r.kernel.org
> Cc: io-uring@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
> include/uapi/linux/io_uring.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
> index 2780bce62faf..9d8861899cde 100644
> --- a/include/uapi/linux/io_uring.h
> +++ b/include/uapi/linux/io_uring.h
> @@ -625,7 +625,7 @@ struct io_uring_buf_ring {
> __u16 resv3;
> __u16 tail;
> };
> - struct io_uring_buf bufs[0];
> + struct io_uring_buf bufs[];
> };
> };
Oops, please ignore. My test build misfired...
>
> --
> 2.34.1
>
--
Kees Cook
Powered by blists - more mailing lists