linux-kernel - Re: [PATCH net-next 1/3] ezchip: Remove some redundant clean-up functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230104205236.3c0f90de@kernel.org>
Date:   Wed, 4 Jan 2023 20:52:36 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/3] ezchip: Remove some redundant clean-up
 functions

On Wed,  4 Jan 2023 22:05:32 +0100 Christophe JAILLET wrote:
> @@ -640,7 +639,6 @@ static s32 nps_enet_remove(struct platform_device *pdev)
>  	struct nps_enet_priv *priv = netdev_priv(ndev);
>  
>  	unregister_netdev(ndev);
> -	netif_napi_del(&priv->napi);
>  	free_netdev(ndev);

This adds an unused variable warning, which is fixed by the next patch.
Could you remove the @priv variable here already?