[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <57a52e19-e121-6082-a4d8-f58ade353782@marcan.st>
Date: Thu, 5 Jan 2023 14:16:27 +0900
From: Hector Martin <marcan@...can.st>
To: Sven Peter <sven@...npeter.dev>, Joerg Roedel <joro@...tes.org>,
Will Deacon <will@...nel.org>,
Robin Murphy <robin.murphy@....com>
Cc: Alyssa Rosenzweig <alyssa@...enzweig.io>,
Janne Grunau <j@...nau.net>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
devicetree@...r.kernel.org, iommu@...ts.linux.dev,
asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] iommu: dart: Support different variants with
different registers
On 2023/01/04 22:43, Sven Peter wrote:
> On Wed, Jan 4, 2023, at 12:00, Hector Martin wrote:
>> + u64 enable_streams;
>> + u64 disable_streams;
> I don't think disable_streams is used anywhere. I assume you just left it in
> here to document it?
Yeah, we don't use this field ever, so we might as well drop it. I'll
leave the #define for T8110 in though, as documentation.
>> + u64 ttbr;
>> + u64 ttbr_valid;
>> + u64 ttbr_addr_off;
>
> This name confused me a bit since off sounds like offset to me while
> this is actually another shift. Can't really think of a better name
> right now though. I'd at least a comment here to describe it.
How about `ttbr_addr_field_shift`?
- Hector
Powered by blists - more mailing lists