linux-kernel - Re: [PATCH 04/10] tty: moxa: Make local var storing tty_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fd3cc28-32f4-f9d7-e9de-00655abcf2b8@kernel.org>
Date:   Thu, 5 Jan 2023 07:04:17 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        linux-serial@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH 04/10] tty: moxa: Make local var storing
 tty_port_initialized() bool

On 04. 01. 23, 16:15, Ilpo Järvinen wrote:
> Return type of tty_port_initialized() is bool, use matching type for
> the local variable.
> 
> Also reorder the local vars to reverse-xmas-tree while at it.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> ---
>   drivers/tty/moxa.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
> index bc474f3c3f8f..2d9635e14ded 100644
> --- a/drivers/tty/moxa.c
> +++ b/drivers/tty/moxa.c
> @@ -1664,8 +1664,8 @@ static int moxa_poll_port(struct moxa_port *p, unsigned int handle,
>   		u16 __iomem *ip)
>   {
>   	struct tty_struct *tty = tty_port_tty_get(&p->port);
> +	bool inited = tty_port_initialized(&p->port);
>   	void __iomem *ofsAddr;
> -	unsigned int inited = tty_port_initialized(&p->port);
>   	u16 intr;
>   
>   	if (tty) {

-- 
js
suse labs