[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y7aS7GrjFDauGm9u@unreal>
Date: Thu, 5 Jan 2023 11:05:48 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Piergiorgio Beruto <piergiorgio.beruto@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, Oleksij Rempel <o.rempel@...gutronix.de>
Subject: Re: [PATCH net-next 5/5] drivers/net/phy: add driver for the onsemi
NCN26000 10BASE-T1S PHY
On Wed, Jan 04, 2023 at 03:07:05PM +0100, Piergiorgio Beruto wrote:
> This patch adds support for the onsemi NCN26000 10BASE-T1S industrial
> Ethernet PHY. The driver supports Point-to-Multipoint operation without
> auto-negotiation and with link control handling. The PHY also features
> PLCA for improving performance in P2MP mode.
>
> Signed-off-by: Piergiorgio Beruto <piergiorgio.beruto@...il.com>
> ---
> MAINTAINERS | 7 ++
> drivers/net/phy/Kconfig | 7 ++
> drivers/net/phy/Makefile | 1 +
> drivers/net/phy/ncn26000.c | 171 +++++++++++++++++++++++++++++++++++++
> 4 files changed, 186 insertions(+)
> create mode 100644 drivers/net/phy/ncn26000.c
<...>
> +static int ncn26000_config_aneg(struct phy_device *phydev)
> +{
> + // Note: the NCN26000 supports only P2MP link mode. Therefore, AN is not
> + // supported. However, this function is invoked by phylib to enable the
> + // PHY, regardless of the AN support.
Please use C-style comments for multi lines blocks.
> + phydev->mdix_ctrl = ETH_TP_MDI_AUTO;
> + phydev->mdix = ETH_TP_MDI;
> +
> + // bring up the link
Thanks
Powered by blists - more mailing lists