linux-kernel - Re: [PATCH v10 07/13] x86/resctrl: Add __init attribute to rdt_get_mon_l3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6597dab2-db66-e4c1-e8e2-b18b2a0bc9e3@intel.com>
Date:   Wed, 4 Jan 2023 16:28:50 -0800
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Babu Moger <babu.moger@....com>, <corbet@....net>,
        <tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>
CC:     <fenghua.yu@...el.com>, <dave.hansen@...ux.intel.com>,
        <x86@...nel.org>, <hpa@...or.com>, <paulmck@...nel.org>,
        <akpm@...ux-foundation.org>, <quic_neeraju@...cinc.com>,
        <rdunlap@...radead.org>, <damien.lemoal@...nsource.wdc.com>,
        <songmuchun@...edance.com>, <peterz@...radead.org>,
        <jpoimboe@...nel.org>, <pbonzini@...hat.com>,
        <chang.seok.bae@...el.com>, <pawan.kumar.gupta@...ux.intel.com>,
        <jmattson@...gle.com>, <daniel.sneddon@...ux.intel.com>,
        <sandipan.das@....com>, <tony.luck@...el.com>,
        <james.morse@....com>, <linux-doc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <bagasdotme@...il.com>,
        <eranian@...gle.com>, <christophe.leroy@...roup.eu>,
        <jarkko@...nel.org>, <adrian.hunter@...el.com>,
        <quic_jiles@...cinc.com>, <peternewman@...gle.com>
Subject: Re: [PATCH v10 07/13] x86/resctrl: Add __init attribute to
 rdt_get_mon_l3_config()

Hi Babu,

On 12/22/2022 3:31 PM, Babu Moger wrote:
> In an upcoming change rdt_get_mon_l3_config() needs to call
> rdt_cpu_has() to query the monitor related features. It cannot be
> called right now because rdt_cpu_has() has the __init attribute but
> rdt_get_mon_l3_config() doesn't.
> 
> Add the __init attribute to rdt_get_mon_l3_config() that is only called
> by get_rdt_mon_resources() that already has the __init attribute. Also
> make rdt_cpu_has() available to by rdt_get_mon_l3_config() via
> the internal header file.
> 
> Signed-off-by: Babu Moger <babu.moger@....com>

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette