linux-kernel - Re: [GIT PULL] fbdev fixes for v6.2-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed7a65bb-f521-e5a5-85eb-0f24b023421b@gmx.de>
Date:   Thu, 5 Jan 2023 11:31:17 +0100
From:   Helge Deller <deller@....de>
To:     Daniel Vetter <daniel@...ll.ch>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [GIT PULL] fbdev fixes for v6.2-rc3

On 1/5/23 11:22, Daniel Vetter wrote:
> On Thu, 5 Jan 2023 at 09:14, Helge Deller <deller@....de> wrote:
>>
>> Hi Linus,
>>
>> please pull the fbdev driver updates for 6.2-rc3, to receive
>> fixes for matroxfb, offb, omapfb and fbmem.
>>
>> Thanks,
>> Helge
>>
>> ----
>>
>> The following changes since commit 1b929c02afd37871d5afb9d498426f83432e71c2:
>>
>>    Linux 6.2-rc1 (2022-12-25 13:41:39 -0800)
>>
>> are available in the Git repository at:
>>
>>    http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git tags/fbdev-for-6.2-rc3
>>
>> for you to fetch changes up to 764043cccd7232a783753a612d628fc0cb7854be:
>>
>>    fbdev: omapfb: avoid stack overflow warning (2023-01-04 19:09:40 +0100)
>>
>> ----------------------------------------------------------------
>> fbdev updates for kernel 6.2-rc3:
>>
>> - Fix Matrox G200eW initialization failure
>> - Fix build failure of offb driver when built as module
>> - Optimize stack usage in omapfb
>> - Prevent use-after-free in fbmem
>>
>> ----------------------------------------------------------------
>> Arnd Bergmann (1):
>>        fbdev: omapfb: avoid stack overflow warning
>>
>> Hang Zhang (1):
>>        fbdev: fbmem: prevent potential use-after-free issues with console_lock()
>
> I looked at this, and even by fbdev locking standards this makes
> absolutely no sense to me. I think this should be dropped before we've
> reached some sort of conclusion on what is going on, or whether this
> is just pure static checker conjecture without fully understanding how
> this is supposed to work really.
> -Daniel

Sure.

I'll send a new pull request where this patch is dropped.

Thanks!
Helge


>
>> Paul Menzel (1):
>>        fbdev: matroxfb: G200eW: Increase max memory from 1 MB to 16 MB
>>
>> Randy Dunlap (1):
>>        fbdev: make offb driver tristate
>>
>> Xu Panda (2):
>>        fbdev: omapfb: use strscpy() to instead of strncpy()
>>        fbdev: atyfb: use strscpy() to instead of strncpy()
>>
>>   drivers/video/fbdev/Kconfig                |  4 ++--
>>   drivers/video/fbdev/aty/atyfb_base.c       |  3 +--
>>   drivers/video/fbdev/core/fbmem.c           |  2 ++
>>   drivers/video/fbdev/matrox/matroxfb_base.c |  4 ++--
>>   drivers/video/fbdev/omap/omapfb_main.c     |  5 ++---
>>   drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 28 ++++++++++++++++++----------
>>   6 files changed, 27 insertions(+), 19 deletions(-)
>
>
>