linux-kernel - Re: [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the GPIO providing driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230105122357.6711ad0c@md1za8fc.ad001.siemens.net>
Date:   Thu, 5 Jan 2023 12:23:57 +0100
From:   Henning Schild <henning.schild@...mens.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Lee Jones <lee@...nel.org>, Pavel Machek <pavel@....cz>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the
 GPIO providing driver

Am Thu, 5 Jan 2023 11:35:48 +0200
schrieb Andy Shevchenko <andriy.shevchenko@...ux.intel.com>:

> On Wed, Jan 04, 2023 at 08:30:05PM +0100, Henning Schild wrote:
> > Am Wed, 4 Jan 2023 17:51:33 +0200
> > schrieb Andy Shevchenko <andriy.shevchenko@...ux.intel.com>:  
> > > On Wed, Jan 04, 2023 at 03:39:24PM +0100, Henning Schild wrote:  
> > > > Am Wed, 4 Jan 2023 14:24:30 +0000
> > > > schrieb Lee Jones <lee@...nel.org>:    
> 
> ...
> 
> > > > As we speak i already have the third box to eventually support,
> > > > which will likely be similar but this time around with
> > > > PINCTRL_ELKHARTLAKE    
> > > 
> > > A bit of offtopic here.
> > > 
> > > Are you able to get / fix / ... the firmware to work with the
> > > upstreamed version of pin control driver for Intel Elkhart Lake?
> > > 
> > > (I'm asking this in terms of the
> > > https://bugzilla.kernel.org/show_bug.cgi?id=213365)
> > >   
> > 
> > I can not tell. At the moment i am in a Siemens internal review
> > where i see code that is not even close to being ready for
> > upstream. Somewhat open-coded again from what it looks like.
> > 
> > And i do not have the machine the code is for.
> > 
> > Let me say "it is complicated" but some point in time a device with
> > LEDs attached to PINCTRL_ELKHARTLAKE will be proposed. Likely by me,
> > when i hopefully have such a device on my desk.  
> 
> Thanks for the information.
> 
> Consider above just as a point to be aware of when you come to
> the productization, so we won't need another pin control driver for
> the same chip.

IIRC we talked about this before in some other thread and the solution
was taking a newer BIOS base version. And since i never heard about
this again i hope people did the right thing.

Henning