linux-kernel - Re: [PATCH 1/2] soc: qcom: dcc: Signedness bug in config_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7017c4e0-16c0-225f-028d-2cf2cb34f360@linaro.org>
Date:   Thu, 5 Jan 2023 12:47:45 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Dan Carpenter <error27@...il.com>,
        Souradeep Chowdhury <quic_schowdhu@...cinc.com>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Alex Elder <elder@...aro.org>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] soc: qcom: dcc: Signedness bug in
 config_reset_write()

The commit message should be written in an imperative manner,
such as "Fix X, make Y do Z"

For the code:

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad

On 5.01.2023 11:53, Dan Carpenter wrote:
> The "ret" variable needs to be signed for the error handling to work.
> 
> Fixes: 4cbe60cf5ad6 ("soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC)")
> Signed-off-by: Dan Carpenter <error27@...il.com>
> ---
>  drivers/soc/qcom/dcc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/dcc.c b/drivers/soc/qcom/dcc.c
> index d4101f79cb5d..1e2cbefc1655 100644
> --- a/drivers/soc/qcom/dcc.c
> +++ b/drivers/soc/qcom/dcc.c
> @@ -808,8 +808,9 @@ static ssize_t config_reset_write(struct file *filp,
>  				  const char __user *user_buf, size_t count,
>  				  loff_t *ppos)
>  {
> -	unsigned int val, ret;
> +	unsigned int val;
>  	struct dcc_drvdata *drvdata = filp->private_data;
> +	int ret;
>  
>  	ret = kstrtouint_from_user(user_buf, count, 0, &val);
>  	if (ret < 0)