linux-kernel - Re: [PATCH v2 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22aab888-75c1-ffad-d72b-f87c9d9d80c8@applied-asynchrony.com>
Date:   Thu, 5 Jan 2023 13:07:07 +0100
From:   Holger Hoffstätte <holger@...lied-asynchrony.com>
To:     David Hildenbrand <david@...hat.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     hughd@...gle.com, hannes@...xchg.org, vincent.whitchurch@...s.com,
        seanjc@...gle.com, rppt@...nel.org, shy828301@...il.com,
        pasha.tatashin@...een.com, paul.gortmaker@...driver.com,
        peterx@...hat.com, vbabka@...e.cz, Liam.Howlett@...cle.com,
        ccross@...gle.com, willy@...radead.org, arnd@...db.de,
        cgel.zte@...il.com, yuzhao@...gle.com, bagasdotme@...il.com,
        suleiman@...gle.com, steven@...uorix.net, heftig@...hlinux.org,
        cuigaosheng1@...wei.com, kirill@...temov.name,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-mm@...ck.org,
        syzbot+91edf9178386a07d06a7@...kaller.appspotmail.com
Subject: Re: [PATCH v2 1/1] mm: fix vma->anon_name memory leak for anonymous
 shmem VMAs

On 2023-01-05 10:03, David Hildenbrand wrote:
> On 05.01.23 03:39, Suren Baghdasaryan wrote:
>> On Wed, Jan 4, 2023 at 5:38 PM Andrew Morton <akpm@...ux-foundation.org> wrote:
>>>
>>> On Wed,  4 Jan 2023 16:02:40 -0800 Suren Baghdasaryan <surenb@...gle.com> wrote:
>>>
>>>> free_anon_vma_name() is missing a check for anonymous shmem VMA which
>>>> leads to a memory leak due to refcount not being dropped.  Fix this by
>>>> calling anon_vma_name_put() unconditionally. It will free vma->anon_name
>>>> whenever it's non-NULL.
>>>>
>>>> Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming")
>>>
>>> A cc:stable is appropriate here, yes?
>>
>> Hmm. The patch we are fixing here was merged in 6.2-rc1. Should I CC
>> stable to fix the previous -rc branch?
>>
> 
> No need for stable if it's not in a release kernel yet.

Commit d09e8ca6cb93 is in 6.1. The fix applies cleanly.

cheers
Holger