[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f5758ec0ee377aec26440f31d82812aa19dbfba8.camel@microchip.com>
Date: Thu, 5 Jan 2023 13:20:45 +0100
From: Steen Hegelund <steen.hegelund@...rochip.com>
To: Dan Carpenter <error27@...il.com>
CC: "David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
<UNGLinuxDriver@...rochip.com>,
Randy Dunlap <rdunlap@...radead.org>,
Casper Andersson <casper.casan@...il.com>,
"Russell King" <rmk+kernel@...linux.org.uk>,
Wan Jiabing <wanjiabing@...o.com>,
"Nathan Huckleberry" <nhuck@...gle.com>,
<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
"Daniel Machon" <daniel.machon@...rochip.com>,
Horatiu Vultur <horatiu.vultur@...rochip.com>,
Lars Povlsen <lars.povlsen@...rochip.com>
Subject: Re: [PATCH net-next 2/8] net: microchip: sparx5: Reset VCAP counter
for new rules
Hi Dan,
On Thu, 2023-01-05 at 13:58 +0300, Dan Carpenter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> [ Email re-arranged because I screwed up - dan]
>
> On Thu, Jan 05, 2023 at 11:43:17AM +0100, Steen Hegelund wrote:
>
> > This series was first sent to net, but the response was that I should go
> > into
> > net-next instead, so it is really a first version in net-next.
> >
> > What was your question? I was not able to find it...
>
> Ugh... Oauth2 code (mutt/msmtp) silently ate my email. Sorry.
>
> > > > @@ -1833,6 +1834,8 @@ int vcap_add_rule(struct vcap_rule *rule)
> > > > ret = vcap_write_rule(ri);
> > > > if (ret)
> > > > pr_err("%s:%d: rule write error: %d\n", __func__,
> > > > __LINE__,
> > > > ret);
>
> There should be a "goto out;" after the pr_err().
Indeed - You are right. I will add that in the next series.
>
> > > > + /* Set the counter to zero */
> > > > + ret = vcap_write_counter(ri, &ctr);
> > > > out:
> > > > mutex_unlock(&ri->admin->lock);
> > > > return ret;
> > >
>
> regards,
> dan carpenter
>
Thanks for the feedback.
BR
Steen
Powered by blists - more mailing lists