lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y7bNot3o3nH/Gxrj@unreal>
Date:   Thu, 5 Jan 2023 15:16:18 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
        saeedm@...dia.com, moshe@...dia.com, shayd@...dia.com
Subject: Re: [PATCH -next] net/mlx5: fix missing mutex_unlock in
 mlx5_fw_fatal_reporter_err_work()

On Thu, Jan 05, 2023 at 07:42:20PM +0800, Yang Yingliang wrote:
> Add missing mutex_unlock() before returning from
> mlx5_fw_fatal_reporter_err_work().
> 
> Fixes: 9078e843efec ("net/mlx5: Avoid recovery in probe flows")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/health.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c
> index 96417c5feed7..879555ba847d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/health.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c
> @@ -677,6 +677,7 @@ static void mlx5_fw_fatal_reporter_err_work(struct work_struct *work)
>  	mutex_lock(&dev->intf_state_mutex);
>  	if (test_bit(MLX5_DROP_NEW_HEALTH_WORK, &health->flags)) {
>  		mlx5_core_err(dev, "health works are not permitted at this stage\n");
> +		mutex_unlock(&dev->intf_state_mutex);
>  		return;
>  	}
>  	mutex_unlock(&dev->intf_state_mutex);

Shay is working to rewrite 9078e843efec ("net/mlx5: Avoid recovery in probe flows") completely.

Thanks

> -- 
> 2.25.1
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ