linux-kernel - Re: [External] Re: [PATCH v2] sock: add tracepoint for send recv length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEEQ3wkD5bX34J36-OJ7WdHX=Y9hwFuoCtZ6_zyngKYrz3y1wQ@mail.gmail.com>
Date:   Fri, 6 Jan 2023 10:57:26 +0800
From:   运辉崔 <cuiyunhui@...edance.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     rostedt@...dmis.org, mhiramat@...nel.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, duanxiongchun@...edance.com,
        kuniyu@...zon.com, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org
Subject: Re: [External] Re: [PATCH v2] sock: add tracepoint for send recv length

On Thu, Jan 5, 2023 at 8:03 PM Paolo Abeni <pabeni@...hat.com> wrote:

> > We can obtain the information with kretprobe, but as we know, kprobe gets
> > the result by trappig in an exception, which loses performance compared
> > to tracepoint. We did a test for performance comparison. The results are
> > as follows. Time per request, sock_sendmsg(k,kr):  12.382ms,
> > tcp_send_length(tracepoint): 11.887ms，without hook：11.222ms
>
> 12 ms per packet? I hope there is a an error in the unit of
> measurement.
>
> I'm unsure the delta wrt kreprobe justifies this change.
>
> In any case you need to include the netdev ML into the recipients list,
> and even Cong Wang, as he provided feedback on v1.
>
> Thanks,
>
> Paolo
>

I will add the record of testing with the tool to the commit log of
v3, and then send the email to netdev ML and CongWang, thank you.