linux-kernel - Re: [v4 1/5] dt-bindings: mfd: Add aspeed pwm-tach binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24DD1FEB-95F3-47BE-BE61-8B0E6FBDE20F@aspeedtech.com>
Date:   Fri, 6 Jan 2023 03:31:15 +0000
From:   Billy Tsai <billy_tsai@...eedtech.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "jdelvare@...e.com" <jdelvare@...e.com>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "joel@....id.au" <joel@....id.au>,
        "andrew@...id.au" <andrew@...id.au>,
        "lee@...nel.org" <lee@...nel.org>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
        "corbet@....net" <corbet@....net>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [v4 1/5] dt-bindings: mfd: Add aspeed pwm-tach binding

On 2022/12/9, 3:48 PM, "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org <mailto:krzysztof.kozlowski@...aro.org>> wrote:


  On 09/12/2022 01:54, Billy Tsai wrote:
  > > > > However I am surprised to see such change, so I have no clue why this
  > > > > was done.
  > > 
  > > > Actually now I see it was like that in previous patch, I just missed it
  > > > during previous review. Anyway this must be fixed.
  > > 
  > > I have two module (PWM and TACH) but share with the same base address,
  > > The PWM will use the offset (N*0x10) + 0x0 and 0x04.
  > > The TACH will use the offset (N*0x10) + 0x8 and 0x0c.
  > > The range of the N is 0~15.
  > > Can you give me some advice to fix this problem without using simple-mfd?


  > Use regular driver which populates children.

I think that my scenario meets the definition in mfd.txt: 
- A range of memory registers containing "miscellaneous system registers" also
  known as a system controller "syscon" or any other memory range containing a
  mix of unrelated hardware devices.
Can you tell me the considerations for not using simple-mfd?

Thanks

Best Regards, 
Billy Tsai