linux-kernel - Re: [PATCH v2] erofs: replace erofs_unzipd workqueue with per-cpu threads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Jan 2023 12:35:59 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sandeep Dhavale <dhavale@...gle.com>, Gao Xiang <xiang@...nel.org>,
        Chao Yu <yuchao0@...wei.com>, Chao Yu <chao@...nel.org>,
        Yue Hu <huyue2@...lpad.com>,
        Jeffle Xu <jefflexu@...ux.alibaba.com>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Sandeep Dhavale <dhavale@...gle.com>, kernel-team@...roid.com,
        linux-erofs@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] erofs: replace erofs_unzipd workqueue with per-cpu
 threads

Hi Sandeep,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on xiang-erofs/dev-test]
[also build test WARNING on xiang-erofs/dev xiang-erofs/fixes linus/master v6.2-rc2 next-20230105]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sandeep-Dhavale/erofs-replace-erofs_unzipd-workqueue-with-per-cpu-threads/20230106-110024
base:   https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git dev-test
patch link:    https://lore.kernel.org/r/20230106025719.3870252-1-dhavale%40google.com
patch subject: [PATCH v2] erofs: replace erofs_unzipd workqueue with per-cpu threads
config: m68k-allmodconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/805027b1ff1976adf5fca411d328a30cea6e4cd6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sandeep-Dhavale/erofs-replace-erofs_unzipd-workqueue-with-per-cpu-threads/20230106-110024
        git checkout 805027b1ff1976adf5fca411d328a30cea6e4cd6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> fs/erofs/zdata.c:197:6: warning: no previous prototype for 'erofs_destroy_worker_pool' [-Wmissing-prototypes]
     197 | void erofs_destroy_worker_pool(void)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +/erofs_destroy_worker_pool +197 fs/erofs/zdata.c

   196	
 > 197	void erofs_destroy_worker_pool(void)
   198	{
   199		unsigned int cpu;
   200		struct kthread_worker *worker;
   201	
   202		for_each_possible_cpu(cpu) {
   203			worker = rcu_dereference_protected(
   204					worker_pool.workers[cpu],
   205					1);
   206			rcu_assign_pointer(worker_pool.workers[cpu], NULL);
   207	
   208			if (worker)
   209				kthread_destroy_worker(worker);
   210		}
   211	
   212		if (worker_pool.unbound_worker)
   213			kthread_destroy_worker(worker_pool.unbound_worker);
   214	
   215		kfree(worker_pool.workers);
   216	}
   217	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (278750 bytes)