linux-kernel - Re: [PATCH -next] thermal: Fix unsigned comparison with less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Jan 2023 07:03:15 +0000
From:   "Zhang, Rui" <rui.zhang@...el.com>
To:     "yang.lee@...ux.alibaba.com" <yang.lee@...ux.alibaba.com>,
        "rafael@...nel.org" <rafael@...nel.org>
CC:     "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "amitk@...nel.org" <amitk@...nel.org>,
        "abaci@...ux.alibaba.com" <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] thermal: Fix unsigned comparison with less than
 zero

On Fri, 2023-01-06 at 08:59 +0800, Yang Li wrote:
> The return value from the call to intel_tcc_get_tjmax() is int, which
> can 
> be a negative error code. However, the return value is being assigned
> to 
> an u32 variable 'tj_max', so making 'tj_max' an int.
> 
> Eliminate the following warning:
> ./drivers/thermal/intel/intel_soc_dts_iosf.c:394:5-11: WARNING:
> Unsigned expression compared with zero: tj_max < 0
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3637
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Thanks for catching this issue.

Acked-by: Zhang Rui <rui.zhang@...el.com>

thanks,
rui

> ---
>  drivers/thermal/intel/intel_soc_dts_iosf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c
> b/drivers/thermal/intel/intel_soc_dts_iosf.c
> index 2138693d8afd..8c26f7b2316b 100644
> --- a/drivers/thermal/intel/intel_soc_dts_iosf.c
> +++ b/drivers/thermal/intel/intel_soc_dts_iosf.c
> @@ -380,7 +380,7 @@ struct intel_soc_dts_sensors
> *intel_soc_dts_iosf_init(
>  {
>  	struct intel_soc_dts_sensors *sensors;
>  	bool notification;
> -	u32 tj_max;
> +	int tj_max;
>  	int ret;
>  	int i;
>