linux-kernel - [PATCH] fs/coredump: fix a compilation issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230106071304.1258905-1-oushixiong@kylinos.cn>
Date:   Fri,  6 Jan 2023 15:13:04 +0800
From:   oushixiong <oushixiong@...inos.cn>
To:     Alexander Viro <viro@...iv.linux.org.uk>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        oushixiong <oushixiong@...inos.cn>, k2ci <kernel-bot@...inos.cn>
Subject: [PATCH] fs/coredump: fix a compilation issue

if CONFIG_ELF_CORE is not set,  it will cause a compilation issue:
   error: ‘dump_emit_page’ defined but not used.

Fixes: 06bbaa6dc53c "[coredump] don't use __kernel_write()"

Reported-by: k2ci <kernel-bot@...inos.cn>
Signed-off-by: oushixiong <oushixiong@...inos.cn>
---
 fs/coredump.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/coredump.c b/fs/coredump.c
index de78bde2991b..95390a73b912 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -838,6 +838,7 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr)
 	}
 }
 
+#ifdef CONFIG_ELF_CORE
 static int dump_emit_page(struct coredump_params *cprm, struct page *page)
 {
 	struct bio_vec bvec = {
@@ -870,6 +871,7 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page)
 
 	return 1;
 }
+#endif
 
 int dump_emit(struct coredump_params *cprm, const void *addr, int nr)
 {
-- 
2.25.1