lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <trinity-fc462dbe-05a4-4a4f-b79a-7d79a2922dd8-1673007511120@3c-app-gmx-bap25> Date: Fri, 6 Jan 2023 13:18:31 +0100 From: Frank Wunderlich <frank-w@...lic-files.de> To: Felix Fietkau <nbd@....name> Cc: netdev@...r.kernel.org, John Crispin <john@...ozen.org>, Sean Wang <sean.wang@...iatek.com>, Mark Lee <Mark-MC.Lee@...iatek.com>, Lorenzo Bianconi <lorenzo@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Matthias Brugger <matthias.bgg@...il.com>, Russell King <linux@...linux.org.uk>, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Aw: Re: Re: Re: [PATCH net v3 4/5] net: ethernet: mtk_eth_soc: drop generic vlan rx offload, only use DSA untagging Hi, update on my tests...something in my systemd-networkd breaks vlan on dsa-port. if i boot with this disabled vlan added manually works on dsa-port and gmac too. so felix you can keep my tested-by. if vlan is working and i activate networkd afterwards vlans are still working...i guess systemd puts the wan-interface into some kind of non-vlan-mode (vlan-filtering?). this is my basic systemd-config: /etc/systemd/network/15-wan.network [Match] Name=wan [Network] BindCarrier=eth0 #static setup Address=192.168.0.19/24 Gateway=192.168.0.10 DNS=192.168.0.10 IPForward=yes /etc/systemd/network/20-lanbr.netdev [NetDev] Name=lanbr0 Kind=bridge [Bridge] DefaultPVID=1 VLANFiltering=1 /etc/systemd/network/22-lanbr.network [Match] Name=lanbr0 [Network] BindCarrier=eth0 ConfigureWithoutCarrier=true Address=192.168.1.1/24 Address=fd00:A::10/64 [DHCPServer] PoolOffset=100 PoolSize=150 /etc/systemd/network/05-eth0.network [Match] Name=eth0 [Network] DHCP=no LinkLocalAddressing=no ConfigureWithoutCarrier=true /etc/systemd/network/21-lanbr-bind.network [Match] Name=lan0 lan1 lan2 lan3 [Network] Bridge=lanbr0 /etc/systemd/network/10-wan.link [Match] OriginalName=wan [Link] Name=wan #MACAddressPolicy=none #MACAddress=08:22:33:44:55:77 regards Frank > Gesendet: Freitag, 30. Dezember 2022 um 17:13 Uhr > Von: "Felix Fietkau" <nbd@....name> > An: "Frank Wunderlich" <frank-w@...lic-files.de> > Cc: netdev@...r.kernel.org, "John Crispin" <john@...ozen.org>, "Sean Wang" <sean.wang@...iatek.com>, "Mark Lee" <Mark-MC.Lee@...iatek.com>, "Lorenzo Bianconi" <lorenzo@...nel.org>, "David S. Miller" <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>, "Paolo Abeni" <pabeni@...hat.com>, "Matthias Brugger" <matthias.bgg@...il.com>, "Russell King" <linux@...linux.org.uk>, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org > Betreff: Re: Aw: Re: Re: [PATCH net v3 4/5] net: ethernet: mtk_eth_soc: drop generic vlan rx offload, only use DSA untagging > > On 30.12.22 16:38, Frank Wunderlich wrote: > > seems only tx is affected on r3, as i see packets on the vlan from my laptop > > > > tcpdump on R3 (e4:b9:7a:f7:c4:8b is mac from laptop): > > > > 13:47:05.265508 e4:b9:7a:f7:c4:8b > ff:ff:ff:ff:ff:ff, ethertype 802.1Q (0x8100), length 577: vlan 500, p 0, ethertype IPv4 (0x0800), 192.168.50.2.59389 > 192.168.50.255.21027: UDP, length 531 > > 13:47:05.265548 e4:b9:7a:f7:c4:8b > ff:ff:ff:ff:ff:ff, ethertype 802.1Q (0x8100), length 577: vlan 600, p 0, ethertype IPv4 (0x0800), 192.168.60.2.59389 > 192.168.60.255.21027: UDP, length 531 > > > > regards Frank > I don't have a setup to test 6.2 on my MT7986 board right now, but I did > test latest OpenWrt with my changes and couldn't reproduce the issue there. > I checked the diff between my tree and upstream and didn't find any > relevant differences in mtk_eth_soc.c > Not sure what's going on or how to narrow it down further. > > - Felix >
Powered by blists - more mailing lists