linux-kernel - [RFC PATCH 3/6] erofs: alloc anonymous file for blob in share domain mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri,  6 Jan 2023 20:53:27 +0800
From:   Jingbo Xu <jefflexu@...ux.alibaba.com>
To:     xiang@...nel.org, chao@...nel.org, linux-erofs@...ts.ozlabs.org
Cc:     huyue2@...lpad.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: [RFC PATCH 3/6] erofs: alloc anonymous file for blob in share domain mode

In prep for the following support for page cache sharing based mmap,
allocate an anonymous file for each blob, so that we can link
associated vma to blobs later.

Since page cache sharing will be enabled only for share domain mode,
prepare anonymous file only in share domain mode.

Signed-off-by: Jingbo Xu <jefflexu@...ux.alibaba.com>
---
 fs/erofs/fscache.c  | 24 +++++++++++++++++++++++-
 fs/erofs/internal.h |  1 +
 2 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
index 4d7785a70926..ea276884f043 100644
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@ -4,6 +4,8 @@
  * Copyright (C) 2022, Bytedance Inc. All rights reserved.
  */
 #include <linux/fscache.h>
+#include <linux/file.h>
+#include <linux/anon_inodes.h>
 #include "internal.h"
 
 static DEFINE_MUTEX(erofs_domain_list_lock);
@@ -316,6 +318,8 @@ const struct address_space_operations erofs_fscache_access_aops = {
 	.readahead = erofs_fscache_readahead,
 };
 
+static const struct file_operations erofs_fscache_meta_fops = {};
+
 static void erofs_fscache_domain_put(struct erofs_domain *domain)
 {
 	mutex_lock(&erofs_domain_list_lock);
@@ -428,6 +432,7 @@ struct erofs_fscache *erofs_fscache_acquire_cookie(struct super_block *sb,
 	struct fscache_cookie *cookie;
 	struct super_block *psb = sb;
 	struct inode *inode;
+	struct file *file;
 	int ret;
 
 	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
@@ -457,10 +462,24 @@ struct erofs_fscache *erofs_fscache_acquire_cookie(struct super_block *sb,
 	mapping_set_gfp_mask(inode->i_mapping, GFP_NOFS);
 	inode->i_private = ctx;
 
+	if (EROFS_SB(sb)->domain_id) {
+		ihold(inode);
+		file = alloc_file_pseudo(inode, erofs_pseudo_mnt, "[erofs]",
+				O_RDONLY, &erofs_fscache_meta_fops);
+		if (IS_ERR(file)) {
+			ret = PTR_ERR(file);
+			iput(inode);
+			goto err_inode;
+		}
+		ctx->file = file;
+	}
+
 	ctx->cookie = cookie;
 	ctx->inode = inode;
 	return ctx;
 
+err_inode:
+	iput(inode);
 err_cookie:
 	fscache_unuse_cookie(cookie, NULL, NULL);
 	fscache_relinquish_cookie(cookie, false);
@@ -473,6 +492,8 @@ static void erofs_fscache_relinquish_cookie(struct erofs_fscache *ctx)
 {
 	fscache_unuse_cookie(ctx->cookie, NULL, NULL);
 	fscache_relinquish_cookie(ctx->cookie, false);
+	if (ctx->file)
+		fput(ctx->file);
 	iput(ctx->inode);
 	kfree(ctx->name);
 	kfree(ctx);
@@ -565,7 +586,8 @@ void erofs_fscache_unregister_cookie(struct erofs_fscache *ctx)
 		mutex_lock(&erofs_domain_cookies_lock);
 		/* drop the ref for the sentinel in pseudo mount */
 		iput(ctx->inode);
-		drop = atomic_read(&ctx->inode->i_count) == 1;
+		/* one initial ref, and one ref for anonymous file */
+		drop = atomic_read(&ctx->inode->i_count) == 2;
 		if (drop)
 			erofs_fscache_relinquish_cookie(ctx);
 		mutex_unlock(&erofs_domain_cookies_lock);
diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
index b3d04bc2d279..24d471fe2fa4 100644
--- a/fs/erofs/internal.h
+++ b/fs/erofs/internal.h
@@ -109,6 +109,7 @@ struct erofs_domain {
 struct erofs_fscache {
 	struct fscache_cookie *cookie;
 	struct inode *inode;	/* anonymous indoe for the blob */
+	struct file *file;	/* anonymous file */
 	struct erofs_domain *domain;
 	char *name;
 };
-- 
2.19.1.6.gb485710b