linux-kernel - Re: [patch] crypto: ccp - Avoid page allocation failure warning for SEV_GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 6 Jan 2023 23:18:57 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     David Rientjes <rientjes@...gle.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Peter Gonda <pgonda@...gle.com>,
        Andy Nguyen <theflow@...gle.com>, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org, John Allen <john.allen@....com>,
        Tom Lendacky <thomas.lendacky@....com>
Subject: Re: [patch] crypto: ccp - Avoid page allocation failure warning for
 SEV_GET_ID2

On Fri, Dec 30, 2022 at 02:18:46PM -0800, David Rientjes wrote:
> For SEV_GET_ID2, the user provided length does not have a specified 
> limitation because the length of the ID may change in the future.  The 
> kernel memory allocation, however, is implicitly limited to 4MB on x86 by 
> the page allocator, otherwise the kzalloc() will fail.
> 
> When this happens, it is best not to spam the kernel log with the warning.  
> Simply fail the allocation and return ENOMEM to the user.
> 
> Fixes: d6112ea0cb34 ("crypto: ccp - introduce SEV_GET_ID2 command")
> Reported-by: Andy Nguyen <theflow@...gle.com>
> Reported-by: Peter Gonda <pgonda@...gle.com>
> Suggested-by: Herbert Xu <herbert@...dor.apana.org.au>
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---
>  drivers/crypto/ccp/sev-dev.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt