linux-kernel - Re: [PATCH][next] udf: remove redundant variable netype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230106161747.a5j4orghkegeiqjg@quack3>
Date:   Fri, 6 Jan 2023 17:17:47 +0100
From:   Jan Kara <jack@...e.cz>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Jan Kara <jack@...e.com>, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] udf: remove redundant variable netype

On Thu 05-01-23 13:49:25, Colin Ian King wrote:
> The variable netype is assigned a value that is never read, the assignment
> is redundant the variable can be removed.
> 
> Cleans up clang scan-build warning:
> fs/exfat/dir.c:1012:5: warning: Value stored to 'step' is never read
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Thanks, I've added the patch to my tree. Just the warning message mentioned
in the changelog is apparently from somewhere else so I've just deleted it
;).

								Honza

> ---
>  fs/udf/truncate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/udf/truncate.c b/fs/udf/truncate.c
> index 036ebd892b85..775edaba82ee 100644
> --- a/fs/udf/truncate.c
> +++ b/fs/udf/truncate.c
> @@ -125,7 +125,7 @@ void udf_discard_prealloc(struct inode *inode)
>  	struct kernel_lb_addr eloc;
>  	uint32_t elen;
>  	uint64_t lbcount = 0;
> -	int8_t etype = -1, netype;
> +	int8_t etype = -1;
>  	struct udf_inode_info *iinfo = UDF_I(inode);
>  	int bsize = 1 << inode->i_blkbits;
>  
> @@ -136,7 +136,7 @@ void udf_discard_prealloc(struct inode *inode)
>  	epos.block = iinfo->i_location;
>  
>  	/* Find the last extent in the file */
> -	while ((netype = udf_next_aext(inode, &epos, &eloc, &elen, 0)) != -1) {
> +	while (udf_next_aext(inode, &epos, &eloc, &elen, 0) != -1) {
>  		brelse(prev_epos.bh);
>  		prev_epos = epos;
>  		if (prev_epos.bh)
> -- 
> 2.30.2
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR