linux-kernel - Re: [PATCH] s390: fix -Wundef warning for CONFIG_KERNEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y7hK8HIULQ8zeiZ3@osiris>
Date:   Fri, 6 Jan 2023 17:23:12 +0100
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390: fix -Wundef warning for CONFIG_KERNEL_ZSTD

On Sat, Jan 07, 2023 at 01:10:23AM +0900, Masahiro Yamada wrote:
> Since commit 80b6093b55e3 ("kbuild: add -Wundef to KBUILD_CPPFLAGS
> for W=1 builds"), building with W=1 detects misuse of #(el)if.
> 
>   $ make W=1 ARCH=s390 CROSS_COMPILE=s390x-linux-gnu-
>     [snip]
>   arch/s390/boot/decompressor.c:28:7: warning: "CONFIG_KERNEL_ZSTD" is not defined, evaluates to 0 [-Wundef]
>      28 | #elif CONFIG_KERNEL_ZSTD
>         |       ^~~~~~~~~~~~~~~~~~
> 
> This issue has been hidden because arch/s390/boot/Makefile overwrites
> KBUILD_CFLAGS, dropping -Wundef.
> 
> CONFIG_KERNEL_ZSTD is a bool option. #elif defined() should be used.
> 
> The line #ifdef CONFIG_KERNEL_BZIP2 is fine, but I changed it for
> consistency.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  arch/s390/boot/decompressor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks!