linux-kernel - Re: [PATCH v6 4/5] arm64: dts: apple: t600x: Add PWM controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ced5bfbc-79f8-156a-32d5-27fe2be67236@marcan.st>
Date:   Sat, 7 Jan 2023 01:51:36 +0900
From:   Hector Martin <marcan@...can.st>
To:     Sasha Finkelstein <fnkl.kernel@...il.com>,
        u.kleine-koenig@...gutronix.de, thierry.reding@...il.com,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org
Cc:     sven@...npeter.dev, alyssa@...enzweig.io, asahi@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-pwm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 4/5] arm64: dts: apple: t600x: Add PWM controller

On 06/01/2023 22.58, Sasha Finkelstein wrote:
> Adds PWM controller and keyboard backlight bindings for M1 Pro/Max MacBook Pros
> 
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@...il.com>
> ---
>  arch/arm64/boot/dts/apple/t600x-die0.dtsi      |  9 +++++++++
>  arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi | 18 ++++++++++++++++++
>  2 files changed, 27 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/apple/t600x-die0.dtsi b/arch/arm64/boot/dts/apple/t600x-die0.dtsi
> index 1c41954e3899..7065045dc43a 100644
> --- a/arch/arm64/boot/dts/apple/t600x-die0.dtsi
> +++ b/arch/arm64/boot/dts/apple/t600x-die0.dtsi
> @@ -154,6 +154,15 @@ i2c5: i2c@...054000 {
>  		status = "disabled";
>  	};
>  
> +	fpwm0: pwm@...030000 {
> +		compatible = "apple,t6000-fpwm", "apple,s5l-fpwm";
> +		reg = <0x3 0x9b030000 0x0 0x4000>;
> +		power-domains = <&ps_fpwm0>;
> +		clocks = <&clkref>;
> +		#pwm-cells = <2>;
> +		status = "disabled";
> +	};
> +

We usually keep device nodes sorted by address, so this is out of order
and should come before i2c (at least). No need to respin just for this
though, I can fix it when I apply it, so:

Acked-by: Hector Martin <marcan@...can.st>

Maintainers: as we usually ask, please merge only the driver commit (#2)
via the PWM tree, we'll take care of DTs/MAINTAINERS/bindings via
asahi-soc so we can avoid serializing/blocking other DT changes.

- Hector