linux-kernel - Re: [PATCH v8 04/16] x86/virt/tdx: Add skeleton to initialize TDX on demand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6e72ab7-eb48-22bb-f7f7-6869408d1dda@intel.com>
Date:   Fri, 6 Jan 2023 09:14:41 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     Kai Huang <kai.huang@...el.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     linux-mm@...ck.org, peterz@...radead.org, tglx@...utronix.de,
        seanjc@...gle.com, pbonzini@...hat.com, dan.j.williams@...el.com,
        rafael.j.wysocki@...el.com, kirill.shutemov@...ux.intel.com,
        ying.huang@...el.com, reinette.chatre@...el.com,
        len.brown@...el.com, tony.luck@...el.com, ak@...ux.intel.com,
        isaku.yamahata@...el.com, chao.gao@...el.com,
        sathyanarayanan.kuppuswamy@...ux.intel.com, bagasdotme@...il.com,
        sagis@...gle.com, imammedo@...hat.com
Subject: Re: [PATCH v8 04/16] x86/virt/tdx: Add skeleton to initialize TDX on
 demand

On 12/8/22 22:52, Kai Huang wrote:
> 
> The TDX module will be initialized in multi-steps defined by the TDX
> module and most of those steps involve a specific SEAMCALL:
> 
>  1) Get the TDX module information and TDX-capable memory regions
>     (TDH.SYS.INFO).
>  2) Build the list of TDX-usable memory regions.
>  3) Construct a list of "TD Memory Regions" (TDMRs) to cover all
>     TDX-usable memory regions.
>  4) Pick up one TDX private KeyID as the global KeyID.
>  5) Configure the TDMRs and the global KeyID to the TDX module
>     (TDH.SYS.CONFIG).
>  6) Configure the global KeyID on all packages (TDH.SYS.KEY.CONFIG).
>  7) Initialize all TDMRs (TDH.SYS.TDMR.INIT).

I don't think you really need this *AND* the "TODO" comments in
init_tdx_module().  Just say:

	Add a placeholder tdx_enable() to initialize the TDX module on
	demand.  The TODO list will be pared down as functionality is
	added.