[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230106164856.1453819-5-steve@sk2.org>
Date: Fri, 6 Jan 2023 17:48:55 +0100
From: Stephen Kitt <steve@....org>
To: Lee Jones <lee@...nel.org>,
Daniel Thompson <daniel.thompson@...aro.org>,
Jingoo Han <jingoohan1@...il.com>
Cc: Sam Ravnborg <sam@...nborg.org>, Stephen Kitt <steve@....org>,
Helge Deller <deller@....de>, dri-devel@...ts.freedesktop.org,
linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH RESEND 4/4] backlight: tosa: Use backlight helper
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt <steve@....org>
---
drivers/video/backlight/tosa_bl.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/video/backlight/tosa_bl.c b/drivers/video/backlight/tosa_bl.c
index 77b71f6c19b5..e338b1f00f6a 100644
--- a/drivers/video/backlight/tosa_bl.c
+++ b/drivers/video/backlight/tosa_bl.c
@@ -50,13 +50,8 @@ static void tosa_bl_set_backlight(struct tosa_bl_data *data, int brightness)
static int tosa_bl_update_status(struct backlight_device *dev)
{
- struct backlight_properties *props = &dev->props;
struct tosa_bl_data *data = bl_get_data(dev);
- int power = max(props->power, props->fb_blank);
- int brightness = props->brightness;
-
- if (power)
- brightness = 0;
+ int brightness = backlight_get_brightness(dev);
tosa_bl_set_backlight(data, brightness);
--
2.30.2
Powered by blists - more mailing lists