linux-kernel - Re: Bug report: the extended PCI config space is missed with 6.2-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230106173341.GA1234930@bhelgaas>
Date:   Fri, 6 Jan 2023 11:33:41 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     "Luck, Tony" <tony.luck@...el.com>
Cc:     "Williams, Dan J" <dan.j.williams@...el.com>,
        "Liang, Kan" <kan.liang@...ux.intel.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "hdegoede@...hat.com" <hdegoede@...hat.com>,
        "kernelorg@...ead.fr" <kernelorg@...ead.fr>,
        "kjhambrick@...il.com" <kjhambrick@...il.com>,
        "2lprbe78@...k.com" <2lprbe78@...k.com>,
        "nicholas.johnson-opensource@...look.com.au" 
        <nicholas.johnson-opensource@...look.com.au>,
        "benoitg@...us.ca" <benoitg@...us.ca>,
        "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
        "wse@...edocomputers.com" <wse@...edocomputers.com>,
        "mumblingdrunkard@...tonmail.com" <mumblingdrunkard@...tonmail.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Box, David E" <david.e.box@...el.com>,
        "Sun, Yunying" <yunying.sun@...el.com>,
        "Jiang, Dave" <dave.jiang@...el.com>
Subject: Re: Bug report: the extended PCI config space is missed with 6.2-rc2

On Thu, Jan 05, 2023 at 06:47:44PM -0600, Bjorn Helgaas wrote:
> On Fri, Jan 06, 2023 at 12:22:09AM +0000, Luck, Tony wrote:
> > > ...and Dave, who reported that CXL enumeration was busted in -rc2, says
> > > this patch fixes that. So you can also add:
> > >
> > > Tested-by: Dave Jiang <dave.jiang@...el.com>
> > 
> > Also seems good for my Broadwell/EDAC system.
> > 
> > Boot messages mentioning MMCONFIG are:
> > 
> > $ dmesg | grep MMCONFIG
> > PCI: MMCONFIG for domain 0000 [bus 00-ff] at [mem 0x80000000-0x8fffffff] (base 0x80000000)
> > PCI: not using MMCONFIG
> > PCI: MMCONFIG for domain 0000 [bus 00-ff] at [mem 0x80000000-0x8fffffff] (base 0x80000000)
> > PCI: MMCONFIG at [mem 0x80000000-0x8fffffff] reserved in ACPI motherboard resources or EFI
> 
> This part looks ok.
> 
> > PCI: MMCONFIG for 0000 [bus00-7f] at [mem 0x80000000-0x87ffffff] (base 0x80000000) (size reduced!)
> > acpi PNP0A03:00: fail to add MMCONFIG information, can't access extended configuration space under this bridge
> > acpi PNP0A03:01: fail to add MMCONFIG information, can't access extended configuration space under this bridge
> > acpi PNP0A08:02: fail to add MMCONFIG information, can't access extended configuration space under this bridge
> > acpi PNP0A08:03: fail to add MMCONFIG information, can't access extended configuration space under this bridge
> 
> But the rest of this still looks like a regression.  From your
> previous dmesg log:
> 
>   PCI: MMCONFIG for domain 0000 [bus 00-ff] at [mem 0x80000000-0x8fffffff] (base 0x80000000)
>   PNP0A03:00: host bridge to domain 0000 [bus ff]
>   PNP0A03:01: host bridge to domain 0000 [bus bf]
>   PNP0A03:02: host bridge to domain 0000 [bus 7f]
>   PNP0A03:03: host bridge to domain 0000 [bus 3f]
>   PNP0A08:00: host bridge to domain 0000 [bus 00-3e]
>   PNP0A08:01: host bridge to domain 0000 [bus 40-7e]
>   PNP0A08:02: host bridge to domain 0000 [bus 80-be]
>   PNP0A08:03: host bridge to domain 0000 [bus c0-fe]
> 
> That MMCONFIG space should cover all those buses, but something is
> going wrong.

Tony, would you mind collecting a dmesg log with "efi=debug"?  I want
to see the EFI_MEMORY_MAPPED_IO size and what we remove from E820.

Bjorn