linux-kernel - Re: [PATCH 510/606] pinctrl: mcp23s08: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Jan 2023 18:51:23 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        kernel@...gutronix.de
Subject: Re: [PATCH 510/606] pinctrl: mcp23s08: Convert to i2c's .probe_new()

Hello Linus,

On Fri, Nov 18, 2022 at 11:44:04PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/pinctrl/pinctrl-mcp23s08_i2c.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-mcp23s08_i2c.c b/drivers/pinctrl/pinctrl-mcp23s08_i2c.c
> index e0b001c8c08c..b635c5737e0c 100644
> --- a/drivers/pinctrl/pinctrl-mcp23s08_i2c.c
> +++ b/drivers/pinctrl/pinctrl-mcp23s08_i2c.c
> @@ -8,8 +8,9 @@
>  
>  #include "pinctrl-mcp23s08.h"
>  
> -static int mcp230xx_probe(struct i2c_client *client, const struct i2c_device_id *id)
> +static int mcp230xx_probe(struct i2c_client *client)
>  {
> +	const struct i2c_device_id *id = i2c_client_get_device_id(client);
>  	struct device *dev = &client->dev;
>  	unsigned int type = id->driver_data;
>  	struct mcp23s08 *mcp;
> @@ -100,7 +101,7 @@ static struct i2c_driver mcp230xx_driver = {
>  		.name	= "mcp230xx",
>  		.of_match_table = mcp23s08_i2c_of_match,
>  	},
> -	.probe		= mcp230xx_probe,
> +	.probe_new	= mcp230xx_probe,
>  	.id_table	= mcp230xx_id,
>  };

To eventually get all drivers converted to probe_new it would be great
if you picked this patch and #511 for pinctrl.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)