linux-kernel - Re: [PATCH RESEND 3/4] backlight: ipaq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7hnyCOlWuJf+obV@ravnborg.org>
Date:   Fri, 6 Jan 2023 19:26:16 +0100
From:   Sam Ravnborg <sam@...nborg.org>
To:     Stephen Kitt <steve@....org>
Cc:     Lee Jones <lee@...nel.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>, linux-fbdev@...r.kernel.org,
        Helge Deller <deller@....de>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper

On Fri, Jan 06, 2023 at 05:48:54PM +0100, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
> 
> Signed-off-by: Stephen Kitt <steve@....org>
Reviewed-by: Sam Ravnborg <sam@...nborg.org>
> ---
>  drivers/video/backlight/ipaq_micro_bl.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/video/backlight/ipaq_micro_bl.c b/drivers/video/backlight/ipaq_micro_bl.c
> index 85b16cc82878..f595b8c8cbb2 100644
> --- a/drivers/video/backlight/ipaq_micro_bl.c
> +++ b/drivers/video/backlight/ipaq_micro_bl.c
> @@ -16,17 +16,12 @@
>  static int micro_bl_update_status(struct backlight_device *bd)
>  {
>  	struct ipaq_micro *micro = dev_get_drvdata(&bd->dev);
> -	int intensity = bd->props.brightness;
> +	int intensity = backlight_get_brightness(bd);
>  	struct ipaq_micro_msg msg = {
>  		.id = MSG_BACKLIGHT,
>  		.tx_len = 3,
>  	};
>  
> -	if (bd->props.power != FB_BLANK_UNBLANK)
> -		intensity = 0;
> -	if (bd->props.state & (BL_CORE_FBBLANK | BL_CORE_SUSPENDED))
> -		intensity = 0;
> -
>  	/*
>  	 * Message format:
>  	 * Byte 0: backlight instance (usually 1)
> -- 
> 2.30.2