linux-kernel - Re: [PATCH 2/2] arm64: dts: rockchip: Add dts for EmbedFire rk3568 lubancat 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d28e1516-f98f-42f4-7a9a-f71c57fe2b64@linaro.org>
Date:   Sat, 7 Jan 2023 13:52:19 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Andy Yan <andyshrk@....com>, heiko@...ech.de,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org
Cc:     lasstp5011@...il.com
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add dts for EmbedFire rk3568
 lubancat 2

On 07/01/2023 12:53, Andy Yan wrote:
> Lubancat 2 is a rk3568 based SBC from EmbedFire.
> 
> Specificati

(...)

> +
> +&pinctrl {
> +	leds {
> +		user_led_pin: user-status-led-pin {
> +			rockchip,pins = <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};
> +
> +	usb {
> +		vcc5v0_usb20_host_en: vcc5v0-usb20-host-en {
> +			rockchip,pins = <0 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +
> +		vcc5v0_usb30_host_en: vcc5v0-usb30-host-en {
> +			rockchip,pins = <0 RK_PD6 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +
> +		vcc5v0_otg_vbus_en: vcc5v0-otg-vbus-en {
> +			rockchip,pins = <0 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};
> +
> +	pcie {
> +		vcc3v3_m2_pcie_en: vcc3v3-m2-pcie-en {
> +			rockchip,pins = <0 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +
> +		vcc3v3_mini_pcie_en: vcc3v3-mini-pcie-en {
> +			rockchip,pins = <3 RK_PC3 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};
> +
> +	pmic {
> +		pmic_int: pmic_int {

No underscores in node names.

> +			rockchip,pins =
> +				<0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +	};
> +};

Best regards,
Krzysztof