linux-kernel - Re: [PATCH -next V13 4/7] riscv: entry: Convert to generic entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 7 Jan 2023 21:57:47 +0800
From:   kernel test robot <lkp@...el.com>
To:     guoren@...nel.org, arnd@...db.de, palmer@...osinc.com,
        tglx@...utronix.de, peterz@...radead.org, luto@...nel.org,
        conor.dooley@...rochip.com, heiko@...ech.de, jszhang@...nel.org,
        lazyparser@...il.com, falcon@...ylab.org, chenhuacai@...nel.org,
        apatel@...tanamicro.com, atishp@...shpatra.org,
        mark.rutland@....com, ben@...adent.org.uk, bjorn@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        Guo Ren <guoren@...ux.alibaba.com>,
        Björn Töpel <bjorn@...osinc.com>,
        Yipeng Zou <zouyipeng@...wei.com>
Subject: Re: [PATCH -next V13 4/7] riscv: entry: Convert to generic entry

Hi,

I love your patch! Yet something to improve:

[auto build test ERROR on next-20230106]

url:    https://github.com/intel-lab-lkp/linux/commits/guoren-kernel-org/compiler_types-h-Add-__noinstr_section-for-noinstr/20230107-194127
patch link:    https://lore.kernel.org/r/20230107113838.3969149-5-guoren%40kernel.org
patch subject: [PATCH -next V13 4/7] riscv: entry: Convert to generic entry
config: riscv-randconfig-r034-20230106
compiler: riscv64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/82d3616db033b052abe2dc3b1481ef5ce474b7ab
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review guoren-kernel-org/compiler_types-h-Add-__noinstr_section-for-noinstr/20230107-194127
        git checkout 82d3616db033b052abe2dc3b1481ef5ce474b7ab
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/kernel/ arch/riscv/mm/ security/apparmor/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   In file included from arch/riscv/kernel/ptrace.c:11:
   arch/riscv/include/asm/syscall.h: In function 'syscall_handler':
>> arch/riscv/include/asm/syscall.h:85:24: error: 'NR_syscalls' undeclared (first use in this function); did you mean 'si_syscall'?
      85 |         if (syscall >= NR_syscalls) {
         |                        ^~~~~~~~~~~
         |                        si_syscall
   arch/riscv/include/asm/syscall.h:85:24: note: each undeclared identifier is reported only once for each function it appears in
--
>> arch/riscv/kernel/signal.c:277:6: warning: no previous prototype for 'arch_do_signal_or_restart' [-Wmissing-prototypes]
     277 | void arch_do_signal_or_restart(struct pt_regs *regs)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~
--
>> arch/riscv/kernel/traps.c:196:6: warning: no previous prototype for 'handle_break' [-Wmissing-prototypes]
     196 | void handle_break(struct pt_regs *regs)
         |      ^~~~~~~~~~~~
   arch/riscv/kernel/traps.c:264:35: warning: no previous prototype for 'do_page_fault' [-Wmissing-prototypes]
     264 | asmlinkage __visible noinstr void do_page_fault(struct pt_regs *regs)
         |                                   ^~~~~~~~~~~~~
   arch/riscv/kernel/traps.c:275:35: warning: no previous prototype for 'do_irq' [-Wmissing-prototypes]
     275 | asmlinkage __visible noinstr void do_irq(struct pt_regs *regs)
         |                                   ^~~~~~
--
>> arch/riscv/mm/fault.c:207:6: warning: no previous prototype for 'handle_page_fault' [-Wmissing-prototypes]
     207 | void handle_page_fault(struct pt_regs *regs)
         |      ^~~~~~~~~~~~~~~~~


vim +85 arch/riscv/include/asm/syscall.h

    76	
    77	typedef long (*syscall_t)(ulong, ulong, ulong, ulong, ulong, ulong, ulong);
    78	static inline void syscall_handler(struct pt_regs *regs, ulong syscall)
    79	{
    80		syscall_t fn;
    81	
    82		regs->epc += 4;
    83		regs->orig_a0 = regs->a0;
    84	
  > 85		if (syscall >= NR_syscalls) {
    86			regs->a0 = -ENOSYS;
    87			return;
    88		}
    89	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (195849 bytes)