[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CANAwSgTiJ9=oA6TWPF+YT2fZd4gDifmG-idW6LfHCh2VGYZoVQ@mail.gmail.com>
Date: Sat, 7 Jan 2023 20:29:45 +0530
From: Anand Moon <linux.amoon@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Neil Armstrong <neil.armstrong@...aro.org>,
Kevin Hilman <khilman@...libre.com>,
Jerome Brunet <jbrunet@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
linux-amlogic@...ts.infradead.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 02/11] ARM: dts: amlogic: Used onboard usb hub reset to
enable usb hub
Hi Krzysztof,
On Wed, 28 Dec 2022 at 20:39, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 28/12/2022 11:03, Anand Moon wrote:
> > On Odroid c1 previously use gpio-hog to reset the usb hub,
> > switch to used on board usb hub reset to enable the usb hub
> > and enable power to usb hub.
> >
> > Add usb hub regulator as per the schematic.
> >
> > Signed-off-by: Anand Moon <linux.amoon@...il.com>
> > ---
> > arch/arm/boot/dts/meson8b-odroidc1.dts | 40 +++++++++++++++++---------
> > 1 file changed, 27 insertions(+), 13 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
> > index 04356bc639fa..3b29169aac43 100644
> > --- a/arch/arm/boot/dts/meson8b-odroidc1.dts
> > +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
> > @@ -185,6 +185,33 @@ vdd_rtc: regulator-vdd-rtc {
> >
> > vin-supply = <&vcc_3v3>;
> > };
> > +
> > + usb_otg_pwr: regulator-usb-pwrs {
> > + compatible = "regulator-fixed";
> > + regulator-name = "USB_OTG_PWR";
> > +
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > +
> > + /* signal name from schematics: PWREN */
> > + gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > + vin-supply = <&p5v0>;
> > + };
> > +
> > + usb {
> > + dr_mode = "host";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + hub@1 {
> > + /* Genesys Logic GL852G-OHG usb hub */
> > + compatible = "genesys,usb5e3,610";
>
> Wrong compatible. Does not match pattern in usb-device.yaml.
>
ok, will fix this in the next version.
>
> Best regards,
> Krzysztof
>
Thanks
-Anand
Powered by blists - more mailing lists