linux-kernel - Re: [PATCH v2 1/2] Revert "ARM: dts: armada-38x: Fix compatible string for gpios"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7mpYFsvLrqpEp7W@lunn.ch>
Date:   Sat, 7 Jan 2023 18:18:24 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Klaus Kudielka <klaus.kudielka@...il.com>
Cc:     Gregory Clement <gregory.clement@...tlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Pali Rohár <pali@...nel.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        Chris Packham <chris.packham@...iedtelesis.co.nz>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] Revert "ARM: dts: armada-38x: Fix compatible
 string for gpios"

On Sat, Jan 07, 2023 at 03:41:48PM +0100, Klaus Kudielka wrote:
> This reverts commit c4de4667f15d04ef5920bacf41e514ec7d1ef03d, which causes
> a regression on Turris Omnia (Armada 385): GPIO interrupts cease to work,
> ending up in the DSA switch being non-functional.
> 
> The blamed commit is incorrect in the first place:
> If compatible = "marvell,armadaxp-gpio", the second (address, size) pair
> of the reg property must to point to the per-CPU interrupt registers
> <0x18800 0x30> / <0x18840 0x30>, and not to the blink enable registers
> <0x181c0 0x08> / <0x181c8 0x08>.
> 
> But even fixing that leaves the GPIO interrupts broken on the Omnia.
> 
> Furthermore:
> Commit 5f79c651e81e explains very well, why the gpio-mvebu driver does not
> work reliably with per-CPU interrupts.
> Commit 988c8c0cd04d deprecates compatible = marvell,armadaxp-gpio for this
> reason.
> 
> Fixes: c4de4667f15d ("ARM: dts: armada-38x: Fix compatible string for gpios")
> Reported-by: Klaus Kudielka <klaus.kudielka@...il.com>
> Link: https://lore.kernel.org/r/f24474e70c1a4e9692bd596ef6d97ceda9511245.camel@gmail.com/
> 
> Signed-off-by: Klaus Kudielka <klaus.kudielka@...il.com>

Hi Klaus

I was hoping Pali would comment, maybe fix it. But i think enough time
has passed, we should accept your reverts.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew