[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230107-sam-video-backlight-drop-fb_blank-v1-11-1bd9bafb351f@ravnborg.org>
Date: Sat, 07 Jan 2023 19:26:25 +0100
From: Sam Ravnborg via B4 Submission Endpoint
<devnull+sam.ravnborg.org@...nel.org>
To: Nicolas Ferre <nicolas.ferre@...rochip.com>,
Helge Deller <deller@....de>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Claudiu Beznea <claudiu.beznea@...rochip.com>,
Antonino Daplas <adaplas@...il.com>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Paul Mackerras <paulus@...ba.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Robin van der Gracht <robin@...tonic.nl>,
Miguel Ojeda <ojeda@...nel.org>, Lee Jones <lee@...nel.org>,
Daniel Thompson <daniel.thompson@...aro.org>,
Jingoo Han <jingoohan1@...il.com>
Cc: linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-omap@...r.kernel.org, linux-staging@...ts.linux.dev,
linuxppc-dev@...ts.ozlabs.org, Stephen Kitt <steve@....org>,
Sam Ravnborg <sam@...nborg.org>
Subject: [PATCH 11/15] powerpc: via-pmu-backlight: Introduce
backlight_get_brightness()
From: Sam Ravnborg <sam@...nborg.org>
Introduce backlight_get_brightness() to simplify logic
and avoid direct access to backlight properties.
Signed-off-by: Sam Ravnborg <sam@...nborg.org>
Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: Sam Ravnborg <sam@...nborg.org>
Cc: linuxppc-dev@...ts.ozlabs.org
---
drivers/macintosh/via-pmu-backlight.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
index 2194016122d2..c2d87e7fa85b 100644
--- a/drivers/macintosh/via-pmu-backlight.c
+++ b/drivers/macintosh/via-pmu-backlight.c
@@ -71,12 +71,7 @@ static int pmu_backlight_get_level_brightness(int level)
static int __pmu_backlight_update_status(struct backlight_device *bd)
{
struct adb_request req;
- int level = bd->props.brightness;
-
-
- if (bd->props.power != FB_BLANK_UNBLANK ||
- bd->props.fb_blank != FB_BLANK_UNBLANK)
- level = 0;
+ int level = backlight_get_brightness(bd);
if (level > 0) {
int pmulevel = pmu_backlight_get_level_brightness(level);
--
2.34.1
Powered by blists - more mailing lists