linux-kernel - Re: [PATCH] iio: temperature: Add MCP9600 thermocouple EMF converter driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202301070907.zPQASOdx-lkp@intel.com>
Date:   Sat, 7 Jan 2023 09:10:12 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andrew Hepp <andrew.hepp@...pp.dev>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        "Andrew.Hepp" <andrew.hepp@...pp.dev>
Subject: Re: [PATCH] iio: temperature: Add MCP9600 thermocouple EMF converter
 driver

Hi Andrew,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linus/master v6.2-rc2 next-20230106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andrew-Hepp/iio-temperature-Add-MCP9600-thermocouple-EMF-converter-driver/20230104-194337
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20230104113612.4732-1-andrew.hepp%40ahepp.dev
patch subject: [PATCH] iio: temperature: Add MCP9600 thermocouple EMF converter driver
config: i386-allmodconfig
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/f917ff9fc4d32cb214e5721fa9ca8dca45bcaf00
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Andrew-Hepp/iio-temperature-Add-MCP9600-thermocouple-EMF-converter-driver/20230104-194337
        git checkout f917ff9fc4d32cb214e5721fa9ca8dca45bcaf00
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/iio/temperature/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/iio/temperature/mcp9600.c:167:12: error: incompatible function pointer types initializing 'void (*)(struct i2c_client *)' with an expression of type 'int (struct i2c_client *)' [-Werror,-Wincompatible-function-pointer-types]
           .remove = mcp9600_remove,
                     ^~~~~~~~~~~~~~
   1 error generated.


vim +167 drivers/iio/temperature/mcp9600.c

   160	
   161	static struct i2c_driver mcp9600_driver = {
   162		.driver = {
   163			.name = "mcp9600",
   164			.of_match_table = mcp9600_of_match,
   165		},
   166		.probe_new = mcp9600_probe,
 > 167		.remove = mcp9600_remove,
   168		.id_table = mcp9600_id
   169	};
   170	module_i2c_driver(mcp9600_driver);
   171	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (282821 bytes)