linux-kernel - Re: [PATCH] drivers: iio: cdc: Drop redundant if check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230108130002.4e0e4f1c@jic23-huawei>
Date:   Sun, 8 Jan 2023 13:00:02 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Alexander Vorwerk <zabe@...rwerk.net>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: iio: cdc: Drop redundant if check

On Thu,  5 Jan 2023 03:53:51 +0100
Alexander Vorwerk <zabe@...rwerk.net> wrote:

> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Alexander Vorwerk <zabe@...rwerk.net>
Applied to the togreg branch of iio.git.

Thanks,

Jonathan

> ---
>  drivers/iio/cdc/ad7746.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/cdc/ad7746.c b/drivers/iio/cdc/ad7746.c
> index 6f68651ce1d5..a1db5469f2d1 100644
> --- a/drivers/iio/cdc/ad7746.c
> +++ b/drivers/iio/cdc/ad7746.c
> @@ -285,8 +285,7 @@ static int ad7746_select_channel(struct iio_dev *indio_dev,
>  		if (ret < 0)
>  			return ret;
>  
> -		if (chip->capdac_set != chan->channel)
> -			chip->capdac_set = chan->channel;
> +		chip->capdac_set = chan->channel;
>  		break;
>  	case IIO_VOLTAGE:
>  	case IIO_TEMP: