linux-kernel - Re: [PATCH] kbuild: rust: remove -v option of scripts/rust_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72nyckkPgbc9y1DS00i1+WvNGcDF7MmWaom89ZCb_ufZxw@mail.gmail.com>
Date:   Sun, 8 Jan 2023 22:56:30 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kbuild@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>,
        rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alex Gaynor <alex.gaynor@...il.com>,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>, Tom Rix <trix@...hat.com>,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] kbuild: rust: remove -v option of scripts/rust_is_available.sh

On Sat, Dec 31, 2022 at 9:27 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> The -v option is passed when this scripts is invoked from Makefile,

scripts -> script

> but not when invoked from Kconfig.
>
> As you can see in scripts/Kconfig.include, the 'success' macro suppresses
> stdout and stderr anyway, so this script does not need to be quiet.

Yeah, let's get rid of the complexity. The script originally was
intended to be usable independently of the `Makefile`, but in the end
we don't really use it like that.

In fact, now we should probably add a warning/error if somebody calls
it directly (and/or set defaults for the variables). I can send a
patch for that on top of this one.

There is a small functional change, in that we will be making an
unneeded call to `cc-version.sh` and another to `$CC` for the Kconfig
case (i.e. the previously non-verbose case), but that seems like a
fine price for the simplicity.

> --- a/scripts/rust_is_available.sh
> +++ b/scripts/rust_is_available.sh

Could you please remove the comment at the top? i.e.:

    #
    # Pass `-v` for human output and more checks (as warnings).

With that:

Reviewed-by: Miguel Ojeda <ojeda@...nel.org>
Tested-by: Miguel Ojeda <ojeda@...nel.org>

If you want me to take it, please let me know.

Cheers,
Miguel